Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate stable-24-3-9-cs-2 into stable-24-3 #9675

Open
wants to merge 6 commits into
base: stable-24-3
Choose a base branch
from

Conversation

fexolm
Copy link
Member

@fexolm fexolm commented Sep 24, 2024

Changelog entry

...

Changelog category

  • New feature
  • Experimental feature
  • Improvement
  • Performance improvement
  • Bugfix
  • Backward incompatible change
  • Documentation (changelog entry is not required)
  • Not for changelog (changelog entry is not required)

Additional information

...

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 08:00:15 UTC Pre-commit check for 9a45d11 has started.
2024-09-24 08:03:25 UTC Build linux-x86_64-release-clang14 is running...
2024-09-24 08:04:40 UTC Check cancelled

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 08:02:05 UTC Pre-commit check for 9a45d11 has started.
2024-09-24 08:04:36 UTC Check cancelled

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 08:02:39 UTC Pre-commit check for 9a45d11 has started.
2024-09-24 08:04:36 UTC Check cancelled

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 08:06:07 UTC Pre-commit check for 4e6610c has started.
2024-09-24 08:09:16 UTC Build linux-x86_64-release-asan is running...
🔴 2024-09-24 08:22:48 UTC Build failed. see the build logs.
🔴 2024-09-24 08:22:50 UTC Tests run skipped.
🔴 2024-09-24 08:23:33 UTC ydbd size 5.5 GiB changed* by +21.9 MiB, which is >= 2.0 MiB vs stable-24-3: Alert

ydbd size dash stable-24-3: be211bb merge: 4e6610c diff diff %
ydbd size 5 935 291 800 Bytes 5 958 208 584 Bytes +21.9 MiB +0.386%
ydbd stripped size 1 488 000 064 Bytes 1 491 655 072 Bytes +3.5 MiB +0.246%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 08:06:18 UTC Pre-commit check for 4e6610c has started.
2024-09-24 08:09:21 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-09-24 08:16:29 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 08:08:06 UTC Pre-commit check for 4e6610c has started.
2024-09-24 08:11:54 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-09-24 08:19:40 UTC Build failed. see the build logs.
🔴 2024-09-24 08:19:42 UTC Tests run skipped.

@maximyurchuk maximyurchuk added the rebase-and-check Rebase PR with the current main and check label Sep 24, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current main and check label Sep 24, 2024
Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 09:50:22 UTC Pre-commit check for 1a3240c has started.
2024-09-24 09:53:33 UTC Build linux-x86_64-release-clang14 is running...
2024-09-24 10:00:30 UTC Check cancelled

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 09:52:59 UTC Pre-commit check for 1a3240c has started.
2024-09-24 09:56:05 UTC Build linux-x86_64-relwithdebinfo is running...
2024-09-24 10:00:42 UTC Check cancelled

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 09:53:05 UTC Pre-commit check for 1a3240c has started.
2024-09-24 09:56:09 UTC Build linux-x86_64-release-asan is running...
2024-09-24 10:00:28 UTC Check cancelled

zverevgeny and others added 5 commits September 24, 2024 12:59
Co-authored-by: Semyon <[email protected]>
Co-authored-by: ivanmorozov333 <[email protected]>
Co-authored-by: Ivan <[email protected]>
Co-authored-by: Artem Alekseev <[email protected]>
Co-authored-by: Alexander Avdonkin <[email protected]>
Co-authored-by: Nikita Vasilev <[email protected]>
Co-authored-by: Vladislav Gogov <[email protected]>
Co-authored-by: Pisarenko Grigoriy <[email protected]>
Co-authored-by: ivanmorozov333 <[email protected]>
Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 10:02:51 UTC Pre-commit check for 573d643 has started.
2024-09-24 10:06:28 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-24 10:33:57 UTC Build successful.
2024-09-24 10:34:12 UTC Tests are running...
🔴 2024-09-24 12:30:33 UTC Test run completed, no test results found for commit a5915f7. Please check test log.
🔴 2024-09-24 12:31:03 UTC ydbd size 5.5 GiB changed* by +21.9 MiB, which is >= 2.0 MiB vs stable-24-3: Alert

ydbd size dash stable-24-3: 0b65df2 merge: 573d643 diff diff %
ydbd size 5 935 292 280 Bytes 5 958 209 064 Bytes +21.9 MiB +0.386%
ydbd stripped size 1 488 000 448 Bytes 1 491 655 456 Bytes +3.5 MiB +0.246%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-09-24 12:31:04 UTC Check cancelled

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 10:03:44 UTC Pre-commit check for 573d643 has started.
2024-09-24 10:06:50 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-24 10:54:03 UTC Build successful.
2024-09-24 10:54:18 UTC Tests are running...
🔴 2024-09-24 12:30:34 UTC Test run completed, no test results found for commit a5915f7. Please check test log.
🔴 2024-09-24 12:31:14 UTC ydbd size 8.2 GiB changed* by +34.0 MiB, which is >= 2.0 MiB vs stable-24-3: Alert

ydbd size dash stable-24-3: 0b65df2 merge: 573d643 diff diff %
ydbd size 8 763 567 296 Bytes 8 799 242 232 Bytes +34.0 MiB +0.407%
ydbd stripped size 479 093 192 Bytes 479 985 320 Bytes +871.2 KiB +0.186%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-09-24 12:31:16 UTC Check cancelled

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 10:04:21 UTC Pre-commit check for 573d643 has started.
2024-09-24 10:07:51 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-24 10:24:37 UTC Build successful.

@fexolm fexolm marked this pull request as ready for review September 24, 2024 10:47
@fexolm fexolm requested a review from a team as a code owner September 24, 2024 10:47
@@ -1 +1 @@
* @ydb-platform/ReleaseApprovers
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, revert this change

@fexolm
Copy link
Member Author

fexolm commented Sep 24, 2024

fixes #9670

@@ -285,7 +285,7 @@ message TTableServiceConfig {
optional bool EnableOlapSink = 55 [default = false];

optional bool EnablePerStatementQueryExecution = 56 [default = false];
optional bool EnableCreateTableAs = 57 [default = true];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikvas0, check this change, please

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 12:33:14 UTC Pre-commit check for 33cc975 has started.
2024-09-24 12:36:20 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-24 13:17:43 UTC Build successful.
2024-09-24 13:17:57 UTC Tests are running...
🔴 2024-09-24 15:28:42 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15210 15094 0 22 49 45

🔴 2024-09-24 15:29:42 UTC ydbd size 5.5 GiB changed* by +21.9 MiB, which is >= 2.0 MiB vs stable-24-3: Alert

ydbd size dash stable-24-3: 492d722 merge: 33cc975 diff diff %
ydbd size 5 935 757 384 Bytes 5 958 670 080 Bytes +21.9 MiB +0.386%
ydbd stripped size 1 488 059 104 Bytes 1 491 710 016 Bytes +3.5 MiB +0.245%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 12:34:36 UTC Pre-commit check for 33cc975 has started.
2024-09-24 12:37:46 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-24 13:43:19 UTC Build successful.
2024-09-24 13:43:33 UTC Tests are running...
🔴 2024-09-24 15:57:12 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76369 62899 0 7 13420 43

🔴 2024-09-24 15:58:01 UTC ydbd size 8.2 GiB changed* by +34.0 MiB, which is >= 2.0 MiB vs stable-24-3: Alert

ydbd size dash stable-24-3: 492d722 merge: 33cc975 diff diff %
ydbd size 8 764 106 712 Bytes 8 799 781 736 Bytes +34.0 MiB +0.407%
ydbd stripped size 479 106 952 Bytes 479 999 144 Bytes +871.3 KiB +0.186%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 12:35:51 UTC Pre-commit check for 33cc975 has started.
2024-09-24 12:38:56 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-24 13:17:14 UTC Build successful.

@zverevgeny zverevgeny linked an issue Sep 24, 2024 that may be closed by this pull request
Copy link
Collaborator

@nikvas0 nikvas0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kqp looks ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate stable-24-3-9-cs-2 into stable-24-3
4 participants