Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delay before shutdown #9688

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pixcc
Copy link
Member

@pixcc pixcc commented Sep 24, 2024

Changelog entry

Add setting to configure delay before node shutdown

Changelog category

  • New feature

Additional information

This setting is needed to make sure that node removal from discovery list reaches the clients

@pixcc pixcc self-assigned this Sep 24, 2024
Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 09:46:07 UTC Pre-commit check linux-x86_64-release-asan for 59a1088 has started.
2024-09-24 09:46:19 UTC Check cancelled

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 09:48:02 UTC Pre-commit check linux-x86_64-release-clang14 for 84ceeac has started.
2024-09-24 09:48:12 UTC Artifacts will be uploaded here
2024-09-24 09:51:30 UTC ya make is running...
🟢 2024-09-24 10:31:27 UTC Build successful.

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 09:48:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for 84ceeac has started.
2024-09-24 09:48:17 UTC Artifacts will be uploaded here
2024-09-24 09:51:42 UTC ya make is running...
🟡 2024-09-24 11:27:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41317 35749 0 4 5463 101

2024-09-24 11:30:51 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-24 11:42:17 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
111 (only retried tests) 21 0 0 0 90

🟢 2024-09-24 11:42:24 UTC Build successful.
🟢 2024-09-24 11:43:10 UTC ydbd size 8.4 GiB changed* by +8.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 922ce5c merge: 84ceeac diff diff %
ydbd size 9 071 190 256 Bytes 9 071 198 880 Bytes +8.4 KiB +0.000%
ydbd stripped size 490 550 600 Bytes 490 550 664 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 09:50:14 UTC Pre-commit check linux-x86_64-release-asan for 84ceeac has started.
2024-09-24 09:50:24 UTC Artifacts will be uploaded here
2024-09-24 09:53:39 UTC ya make is running...
🔴 2024-09-24 11:59:30 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11917 11726 0 34 38 119

🟢 2024-09-24 12:00:37 UTC Build successful.
🟢 2024-09-24 12:01:11 UTC ydbd size 5.7 GiB changed* by +4.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 922ce5c merge: 84ceeac diff diff %
ydbd size 6 079 178 392 Bytes 6 079 182 952 Bytes +4.5 KiB +0.000%
ydbd stripped size 1 519 930 128 Bytes 1 519 930 512 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@@ -1732,6 +1735,7 @@ void TKikimrRunner::KikimrStop(bool graceful) {

if (EnabledGrpcService) {
ActorSystem->Send(new IEventHandle(NGRpcService::CreateGrpcPublisherServiceActorId(), {}, new TEvents::TEvPoisonPill));
Sleep(DelayBeforeShutdown);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно дрейнить сессии и таблетки, но нельзя тушить актор-систему, если с начала KikimrStop() прошло меньше, чем DelayBeforeShutdown секунд. Да и саму настройку в таком случае можно переименовать, потому эта задерэка не безусловная.

@pixcc pixcc linked an issue Sep 24, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable minimum waiting time before stopping the YDB process
2 participants