-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add delay before shutdown #9688
base: main
Are you sure you want to change the base?
Conversation
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
@@ -1732,6 +1735,7 @@ void TKikimrRunner::KikimrStop(bool graceful) { | |||
|
|||
if (EnabledGrpcService) { | |||
ActorSystem->Send(new IEventHandle(NGRpcService::CreateGrpcPublisherServiceActorId(), {}, new TEvents::TEvPoisonPill)); | |||
Sleep(DelayBeforeShutdown); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Можно дрейнить сессии и таблетки, но нельзя тушить актор-систему, если с начала KikimrStop()
прошло меньше, чем DelayBeforeShutdown
секунд. Да и саму настройку в таком случае можно переименовать, потому эта задерэка не безусловная.
Changelog entry
Add setting to configure delay before node shutdown
Changelog category
Additional information
This setting is needed to make sure that node removal from discovery list reaches the clients