Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speed up compaction preparing #9698

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

speed up compaction preparing #9698

wants to merge 6 commits into from
+97 −37

Conversation

ivanmorozov333
Copy link
Collaborator

  • Performance improvement

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 11:20:27 UTC Pre-commit check linux-x86_64-release-clang14 for 8bb0d82 has started.
⚪ 2024-09-24 11:21:46 UTC Artifacts will be uploaded here
⚪ 2024-09-24 11:25:12 UTC ya make is running...
🟢 2024-09-24 11:39:59 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 11:21:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8bb0d82 has started.
⚪ 2024-09-24 11:22:05 UTC Artifacts will be uploaded here
⚪ 2024-09-24 11:25:34 UTC ya make is running...
⚫ 2024-09-24 12:22:59 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 11:22:26 UTC Pre-commit check linux-x86_64-release-asan for 8bb0d82 has started.
⚪ 2024-09-24 11:22:36 UTC Artifacts will be uploaded here
⚪ 2024-09-24 11:25:36 UTC ya make is running...
⚫ 2024-09-24 12:22:21 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 12:24:33 UTC Pre-commit check linux-x86_64-release-clang14 for bdfc3c6 has started.
⚪ 2024-09-24 12:24:42 UTC Artifacts will be uploaded here
⚪ 2024-09-24 12:28:02 UTC ya make is running...
🔴 2024-09-24 12:37:20 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 12:24:41 UTC Pre-commit check linux-x86_64-release-asan for bdfc3c6 has started.
⚪ 2024-09-24 12:24:51 UTC Artifacts will be uploaded here
⚪ 2024-09-24 12:28:06 UTC ya make is running...
🔴 2024-09-24 12:37:02 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 12:24:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for bdfc3c6 has started.
⚪ 2024-09-24 12:25:03 UTC Artifacts will be uploaded here
⚪ 2024-09-24 12:28:10 UTC ya make is running...
🔴 2024-09-24 12:35:38 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 12:50:05 UTC Pre-commit check linux-x86_64-release-asan for 3adfe85 has started.
⚪ 2024-09-24 12:50:15 UTC Artifacts will be uploaded here
⚪ 2024-09-24 12:53:33 UTC ya make is running...
⚫ 2024-09-24 13:13:39 UTC Check cancelled

nikvas0
nikvas0 previously approved these changes Sep 24, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 12:51:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3adfe85 has started.
⚪ 2024-09-24 12:51:57 UTC Artifacts will be uploaded here
⚪ 2024-09-24 12:55:05 UTC ya make is running...
⚫ 2024-09-24 13:13:30 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 12:51:56 UTC Pre-commit check linux-x86_64-release-clang14 for 3adfe85 has started.
⚪ 2024-09-24 12:51:59 UTC Artifacts will be uploaded here
⚪ 2024-09-24 12:55:04 UTC ya make is running...
⚫ 2024-09-24 13:13:27 UTC Check cancelled

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review September 24, 2024 13:16
@ivanmorozov333 ivanmorozov333 requested review from a team as code owners September 24, 2024 13:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 13:18:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for 877cb9e has started.
⚪ 2024-09-24 13:18:43 UTC Artifacts will be uploaded here
⚪ 2024-09-24 13:21:57 UTC ya make is running...
🟡 2024-09-24 15:37:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79752 65819 0 6 13825 102

⚪ 2024-09-24 15:45:39 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-24 15:57:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
112 (only retried tests) 18 0 1 0 93

⚪ 2024-09-24 15:57:15 UTC ya make is running... (failed tests rerun, try 3)
🟡 2024-09-24 16:07:58 UTC ydbd size 8.5 GiB changed* by +152.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 63a6a81 merge: 877cb9e diff diff %
ydbd size 9 073 184 704 Bytes 9 073 340 752 Bytes +152.4 KiB +0.002%
ydbd stripped size 490 587 400 Bytes 490 589 576 Bytes +2.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2024-09-24 16:08:00 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 13:21:15 UTC Pre-commit check linux-x86_64-release-asan for 877cb9e has started.
⚪ 2024-09-24 13:21:26 UTC Artifacts will be uploaded here
⚪ 2024-09-24 13:24:35 UTC ya make is running...
🔴 2024-09-24 15:20:48 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17265 17017 0 65 67 116

🟢 2024-09-24 15:22:14 UTC Build successful.
🟢 2024-09-24 15:22:50 UTC ydbd size 5.7 GiB changed* by +94.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 63a6a81 merge: 877cb9e diff diff %
ydbd size 6 080 250 272 Bytes 6 080 347 016 Bytes +94.5 KiB +0.002%
ydbd stripped size 1 520 057 904 Bytes 1 520 070 832 Bytes +12.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 13:21:42 UTC Pre-commit check linux-x86_64-release-clang14 for 877cb9e has started.
⚪ 2024-09-24 13:21:52 UTC Artifacts will be uploaded here
⚪ 2024-09-24 13:25:12 UTC ya make is running...
🟢 2024-09-24 13:35:02 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 16:09:35 UTC Pre-commit check linux-x86_64-release-asan for 58a6ea4 has started.
⚪ 2024-09-24 16:10:11 UTC Artifacts will be uploaded here
⚪ 2024-09-24 16:13:55 UTC ya make is running...
🔴 2024-09-24 18:13:28 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17257 17059 0 37 45 116

🟢 2024-09-24 18:14:55 UTC Build successful.
🟡 2024-09-24 18:15:27 UTC ydbd size 5.7 GiB changed* by +154.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 92d046c merge: 58a6ea4 diff diff %
ydbd size 6 080 340 816 Bytes 6 080 499 056 Bytes +154.5 KiB +0.003%
ydbd stripped size 1 520 063 856 Bytes 1 520 083 408 Bytes +19.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 16:13:18 UTC Pre-commit check linux-x86_64-release-clang14 for 58a6ea4 has started.
⚪ 2024-09-24 16:13:27 UTC Artifacts will be uploaded here
⚪ 2024-09-24 16:16:34 UTC ya make is running...
🟢 2024-09-24 16:38:19 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 16:22:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for 58a6ea4 has started.
⚪ 2024-09-24 16:23:32 UTC Artifacts will be uploaded here
⚪ 2024-09-24 16:27:15 UTC ya make is running...
🟡 2024-09-24 17:57:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79751 65824 0 2 13825 100

⚪ 2024-09-24 18:05:25 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-24 18:16:55 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
105 (only retried tests) 15 0 0 0 90

🟢 2024-09-24 18:17:02 UTC Build successful.
🟡 2024-09-24 18:17:48 UTC ydbd size 8.5 GiB changed* by +153.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1a5bc4d merge: 58a6ea4 diff diff %
ydbd size 9 073 348 272 Bytes 9 073 505 560 Bytes +153.6 KiB +0.002%
ydbd stripped size 490 590 344 Bytes 490 592 456 Bytes +2.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikvas0 nikvas0 nikvas0 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanmorozov333 @nikvas0