Do not paint red for asan #9704

maximyurchuk · 2024-09-24T12:28:12Z

Changelog entry

Do not paint red for asan in case of fail, because it is not blocking policy yet

Changelog category

Not for changelog (changelog entry is not required)

Additional information

github-actions · 2024-09-24T12:28:51Z

⚪ 2024-09-24 12:28:50 UTC Pre-commit check linux-x86_64-release-asan for 0963022 has started.
⚪ 2024-09-24 12:29:31 UTC Artifacts will be uploaded here
⚪ 2024-09-24 12:32:25 UTC ya make is running...

github-actions · 2024-09-24T12:31:20Z

⚪ 2024-09-24 12:31:19 UTC Pre-commit check linux-x86_64-release-clang14 for 0963022 has started.
⚪ 2024-09-24 12:31:28 UTC Artifacts will be uploaded here
⚪ 2024-09-24 12:33:48 UTC ya make is running...
🟢 2024-09-24 12:33:56 UTC Build successful.

github-actions · 2024-09-24T12:31:23Z

⚪ 2024-09-24 12:31:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0963022 has started.
⚪ 2024-09-24 12:31:32 UTC Artifacts will be uploaded here
⚪ 2024-09-24 12:34:01 UTC ya make is running...

github-actions · 2024-09-24T12:45:25Z

⚪ 2024-09-24 12:45:24 UTC Pre-commit check linux-x86_64-release-asan for 33e4340 has started.
⚪ 2024-09-24 12:45:35 UTC Artifacts will be uploaded here
⚪ 2024-09-24 12:47:54 UTC ya make is running...

github-actions · 2024-09-24T12:45:59Z

⚪ 2024-09-24 12:45:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for 33e4340 has started.
⚪ 2024-09-24 12:46:09 UTC Artifacts will be uploaded here
⚪ 2024-09-24 12:48:28 UTC ya make is running...

github-actions · 2024-09-24T12:46:01Z

⚪ 2024-09-24 12:46:00 UTC Pre-commit check linux-x86_64-release-clang14 for 33e4340 has started.
⚪ 2024-09-24 12:46:10 UTC Artifacts will be uploaded here
⚪ 2024-09-24 12:48:28 UTC ya make is running...
🟢 2024-09-24 12:48:35 UTC Build successful.

github-actions · 2024-09-24T12:51:23Z

⚪ 2024-09-24 12:51:22 UTC Pre-commit check linux-x86_64-release-asan for 1331eb0 has started.
⚪ 2024-09-24 12:51:46 UTC Artifacts will be uploaded here
⚪ 2024-09-24 12:54:07 UTC ya make is running...
🟢 2024-09-24 12:54:12 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
0	0	0	0	0	0

🟢 2024-09-24 12:54:17 UTC Build successful.

github-actions · 2024-09-24T12:51:47Z

⚪ 2024-09-24 12:51:46 UTC Pre-commit check linux-x86_64-release-clang14 for 1331eb0 has started.
⚪ 2024-09-24 12:51:49 UTC Artifacts will be uploaded here
⚪ 2024-09-24 12:54:08 UTC ya make is running...
🟢 2024-09-24 12:54:15 UTC Build successful.

github-actions · 2024-09-24T12:56:35Z

⚪ 2024-09-24 12:56:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1331eb0 has started.
⚪ 2024-09-24 12:57:29 UTC Artifacts will be uploaded here
⚪ 2024-09-24 13:00:17 UTC ya make is running...
🟢 2024-09-24 13:00:22 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
0	0	0	0	0	0

🟢 2024-09-24 13:00:27 UTC Build successful.

github-actions · 2024-09-24T13:36:56Z

⚪ 2024-09-24 13:36:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for cf1eee1 has started.
⚪ 2024-09-24 13:37:41 UTC Artifacts will be uploaded here
⚪ 2024-09-24 13:40:13 UTC ya make is running...
🟢 2024-09-24 13:40:18 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
0	0	0	0	0	0

🟢 2024-09-24 13:40:24 UTC Build successful.

github-actions · 2024-09-24T13:37:20Z

⚪ 2024-09-24 13:37:19 UTC Pre-commit check linux-x86_64-release-asan for cf1eee1 has started.
⚪ 2024-09-24 13:37:23 UTC Artifacts will be uploaded here
⚪ 2024-09-24 13:39:48 UTC ya make is running...
🟢 2024-09-24 13:39:53 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
0	0	0	0	0	0

🟢 2024-09-24 13:39:59 UTC Build successful.

github-actions · 2024-09-24T13:40:27Z

⚪ 2024-09-24 13:40:26 UTC Pre-commit check linux-x86_64-release-clang14 for cf1eee1 has started.
⚪ 2024-09-24 13:40:30 UTC Artifacts will be uploaded here
⚪ 2024-09-24 13:42:50 UTC ya make is running...
🟢 2024-09-24 13:42:57 UTC Build successful.

github-actions · 2024-09-24T14:52:50Z

⚪ 2024-09-24 14:52:49 UTC Pre-commit check linux-x86_64-release-clang14 for bc43ea0 has started.
⚪ 2024-09-24 14:53:00 UTC Artifacts will be uploaded here
⚪ 2024-09-24 14:55:28 UTC ya make is running...
🟢 2024-09-24 14:55:36 UTC Build successful.

github-actions · 2024-09-24T14:57:35Z

⚪ 2024-09-24 14:57:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for bc43ea0 has started.
⚪ 2024-09-24 14:57:56 UTC Artifacts will be uploaded here
⚪ 2024-09-24 15:00:15 UTC ya make is running...
🟢 2024-09-24 15:00:21 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
0	0	0	0	0	0

🟢 2024-09-24 15:00:26 UTC Build successful.

github-actions · 2024-09-24T15:16:41Z

⚪ 2024-09-24 15:16:40 UTC Pre-commit check linux-x86_64-release-asan for bc43ea0 has started.
⚪ 2024-09-24 15:16:52 UTC Artifacts will be uploaded here
⚪ 2024-09-24 15:19:17 UTC ya make is running...
🟢 2024-09-24 15:19:23 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
0	0	0	0	0	0

🟢 2024-09-24 15:19:28 UTC Build successful.

github-actions · 2024-09-24T15:30:14Z

⚪ 2024-09-24 15:30:13 UTC Pre-commit check linux-x86_64-release-asan for bf30554 has started.
⚪ 2024-09-24 15:31:11 UTC Artifacts will be uploaded here
⚪ 2024-09-24 15:34:00 UTC ya make is running...
🟢 2024-09-24 15:34:05 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
0	0	0	0	0	0

🟢 2024-09-24 15:34:10 UTC Build successful.

github-actions · 2024-09-24T15:32:01Z

⚪ 2024-09-24 15:32:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for bf30554 has started.
⚪ 2024-09-24 15:32:11 UTC Artifacts will be uploaded here
⚪ 2024-09-24 15:34:32 UTC ya make is running...
🟢 2024-09-24 15:34:37 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
0	0	0	0	0	0

🟢 2024-09-24 15:34:42 UTC Build successful.

github-actions · 2024-09-24T15:32:05Z

⚪ 2024-09-24 15:32:04 UTC Pre-commit check linux-x86_64-release-clang14 for bf30554 has started.
⚪ 2024-09-24 15:32:14 UTC Artifacts will be uploaded here
⚪ 2024-09-24 15:34:35 UTC ya make is running...
🟢 2024-09-24 15:34:43 UTC Build successful.

nikitka · 2024-09-25T09:54:35Z

.github/scripts/tests/generate-summary.py

        overall_status = "failure"
    else:
        overall_status = "success"

-    color, text = get_comment_text(summary, args.summary_links, is_last_retry=bool(args.is_last_retry))
+    color, text = get_comment_text(summary, args.summary_links, is_last_retry=bool(args.is_last_retry), is_test_result_ignored=(args.is_test_result_ignored))


Extra parentheses here

nikitka · 2024-09-25T09:56:23Z

.github/actions/test_ya/action.yml

@@ -531,7 +538,9 @@ runs:
      if: inputs.run_tests
      shell: bash
      run: |
-        .github/scripts/tests/fail-checker.py "$LAST_JUNIT_REPORT_XML"
+        if [ $IS_TEST_RESULT_IGNORED == 0 ];then


Also, please add whitespace here

github-actions · 2024-09-25T10:06:42Z

⚪ 2024-09-25 10:06:41 UTC Pre-commit check linux-x86_64-release-asan for 05800ff has started.
⚪ 2024-09-25 10:07:28 UTC Artifacts will be uploaded here
⚪ 2024-09-25 10:10:24 UTC ya make is running...
🟢 2024-09-25 10:10:29 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
0	0	0	0	0	0

🟢 2024-09-25 10:10:35 UTC Build successful.

github-actions · 2024-09-25T10:07:15Z

⚪ 2024-09-25 10:07:15 UTC Pre-commit check linux-x86_64-release-clang14 for 05800ff has started.
⚪ 2024-09-25 10:07:24 UTC Artifacts will be uploaded here
⚪ 2024-09-25 10:09:43 UTC ya make is running...
🟢 2024-09-25 10:09:50 UTC Build successful.

github-actions · 2024-09-25T10:08:42Z

⚪ 2024-09-25 10:08:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for 05800ff has started.
⚪ 2024-09-25 10:09:27 UTC Artifacts will be uploaded here
⚪ 2024-09-25 10:12:21 UTC ya make is running...
🟢 2024-09-25 10:12:27 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
0	0	0	0	0	0

🟢 2024-09-25 10:12:33 UTC Build successful.

Do not paint red for asan

caf3599

github-actions bot added the new-feature label Sep 24, 2024

fix

b1ace33

fix

be9d693

fix

a434d9b

fix

ea4ac9f

fix

01eefa9

maximyurchuk requested a review from nikitka September 25, 2024 08:56

github-actions bot added not-for-changelog and removed new-feature labels Sep 25, 2024

maximyurchuk marked this pull request as ready for review September 25, 2024 08:58

nikitka reviewed Sep 25, 2024

View reviewed changes

nikitka requested changes Sep 25, 2024

View reviewed changes

review fixes

b59d1e3

nikitka approved these changes Sep 25, 2024

View reviewed changes

maximyurchuk merged commit 5efac58 into ydb-platform:main Sep 25, 2024
12 checks passed

This was referenced Sep 25, 2024

YQ-3689 added database id for workload manager #9768

Merged

YQ-3704 RD use CH udf in json parsing #9878

Merged

YQ-3703 pushdown for extract members in PQ provider #9939

Merged

GrigoriyPA mentioned this pull request Oct 8, 2024

YQ-3722 add simdjson parser into RD #10204

Merged

This was referenced Oct 21, 2024

Fix kafka cdc read and login without @ #10678

Merged

Allow short auto partitioning strategies yql #10701

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not paint red for asan #9704

Do not paint red for asan #9704

maximyurchuk commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

nikitka Sep 25, 2024

nikitka Sep 25, 2024

github-actions bot commented Sep 25, 2024 •

edited

Loading

github-actions bot commented Sep 25, 2024 •

edited

Loading

github-actions bot commented Sep 25, 2024 •

edited

Loading

Do not paint red for asan #9704

Do not paint red for asan #9704

Conversation

maximyurchuk commented Sep 24, 2024 • edited Loading

Changelog entry

Changelog category

Additional information

github-actions bot commented Sep 24, 2024 • edited Loading

github-actions bot commented Sep 24, 2024 • edited Loading

github-actions bot commented Sep 24, 2024 • edited Loading

github-actions bot commented Sep 24, 2024 • edited Loading

github-actions bot commented Sep 24, 2024 • edited Loading

github-actions bot commented Sep 24, 2024 • edited Loading

github-actions bot commented Sep 24, 2024 • edited Loading

github-actions bot commented Sep 24, 2024 • edited Loading

github-actions bot commented Sep 24, 2024 • edited Loading

github-actions bot commented Sep 24, 2024 • edited Loading

github-actions bot commented Sep 24, 2024 • edited Loading

github-actions bot commented Sep 24, 2024 • edited Loading

github-actions bot commented Sep 24, 2024 • edited Loading

github-actions bot commented Sep 24, 2024 • edited Loading

github-actions bot commented Sep 24, 2024 • edited Loading

github-actions bot commented Sep 24, 2024 • edited Loading

github-actions bot commented Sep 24, 2024 • edited Loading

github-actions bot commented Sep 24, 2024 • edited Loading

nikitka Sep 25, 2024

Choose a reason for hiding this comment

nikitka Sep 25, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 25, 2024 • edited Loading

github-actions bot commented Sep 25, 2024 • edited Loading

github-actions bot commented Sep 25, 2024 • edited Loading

maximyurchuk commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 25, 2024 •

edited

Loading

github-actions bot commented Sep 25, 2024 •

edited

Loading

github-actions bot commented Sep 25, 2024 •

edited

Loading