WIP: split-table: split Table interface by behavior #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavrukov
commented
Jan 31, 2024
| public interface BaseTable<T extends Entity<T>> { | ||
| Class<T> getType(); | ||
|
|
||
| FirstLevelCache getFirstLevelCache(); |
There was a problem hiding this comment.
This function had default realization, which returned null; I think it isn't needed.
There was a problem hiding this comment.
This function should not be in Table, ever.
Strange that we have it there now.
There was a problem hiding this comment.
But it using in default Table methods. Do you think that its better to leave it in Table?
lavrukov
commented
Jan 31, 2024
| } | ||
|
|
||
| default <ID extends Entity.Id<T>> void delete(Range<ID> range) { | ||
| findIds(range).forEach(this::delete); |
There was a problem hiding this comment.
this was marked with unsafe, but it don't look like it
There was a problem hiding this comment.
Default implementation is safe but YDB implementation isnlikely a blind delete (without reading rows in the range first)
nvamelichev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Table interface is too huge and contains several entities that are well separated by behavior. To simplify navigation and plan a little for the future, I propose to distribute methods from Table to new interfaces