Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1220: Replace usage of Collections.unmodifableList with org.cactoos.list.Immutable #1432

Merged
merged 6 commits into from
Sep 4, 2020

Conversation

andreoss
Copy link
Contributor

Per #1220

  • Replace with Immutable
  • Add to forbidden-apis.txt

@andreoss andreoss marked this pull request as ready for review August 31, 2020 19:52
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2020

Codecov Report

Merging #1432 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1432   +/-   ##
=========================================
  Coverage     89.81%   89.81%           
- Complexity     1678     1681    +3     
=========================================
  Files           277      279    +2     
  Lines          4004     4014   +10     
  Branches        211      211           
=========================================
+ Hits           3596     3605    +9     
  Misses          376      376           
- Partials         32       33    +1     
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/cactoos/iterable/Matched.java 100.00% <100.00%> (ø) 10.00 <0.00> (ø)
...rc/main/java/org/cactoos/iterator/Partitioned.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
src/main/java/org/cactoos/list/Immutable.java 100.00% <100.00%> (ø) 27.00 <1.00> (ø)
src/main/java/org/cactoos/scalar/Solid.java 90.00% <0.00%> (-10.00%) 3.00% <0.00%> (-1.00%)
src/main/java/org/cactoos/RepeatedProc.java
src/main/java/org/cactoos/func/RepeatedProc.java 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)
...c/main/java/org/cactoos/func/RepeatedCallable.java 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)
src/main/java/org/cactoos/text/Sticky.java 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e21e285...072fdcb. Read the comment docs.

@victornoel
Copy link
Collaborator

@0crat status

@0crat
Copy link
Collaborator

0crat commented Sep 4, 2020

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

  • The job #1432 is in scope for 3days
  • The role is REV
  • The job is not assigned to anyone
  • The budget is not set yet
  • These users are banned and won't be assigned:
  • Job footprint (restricted area)

@victornoel
Copy link
Collaborator

@0crat assign me

Copy link
Collaborator

@victornoel victornoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreoss here are some comments

src/main/java/org/cactoos/iterator/Partitioned.java Outdated Show resolved Hide resolved
@victornoel
Copy link
Collaborator

@andreoss excellent, thank you very mch :)

@victornoel
Copy link
Collaborator

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Sep 4, 2020

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 82a1422 into yegor256:master Sep 4, 2020
@rultor
Copy link
Collaborator

rultor commented Sep 4, 2020

@rultor merge

@victornoel Done! FYI, the full log is here (took me 11min)

@0crat
Copy link
Collaborator

0crat commented Sep 4, 2020

Job was finished in 6 hours, bonus for fast delivery is possible (see §36)

@0crat 0crat removed the 0crat/scope label Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants