Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#1223) Replace static factory methods with direct call to new #1433

Merged
merged 2 commits into from
Sep 4, 2020
Merged

(#1223) Replace static factory methods with direct call to new #1433

merged 2 commits into from
Sep 4, 2020

Conversation

andreoss
Copy link
Contributor

@andreoss andreoss commented Sep 1, 2020

Per #1223:

  • Replace static methods with objects
  • Update puzzle

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2020 •
edited
Loading

Codecov Report

Merging #1433 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1433      +/-   ##
============================================
+ Coverage     89.81%   89.83%   +0.02%     
- Complexity     1678     1682       +4     
============================================
  Files           277      279       +2     
  Lines          4004     4014      +10     
  Branches        211      211              
============================================
+ Hits           3596     3606      +10     
  Misses          376      376              
  Partials         32       32
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/cactoos/RepeatedProc.java
src/main/java/org/cactoos/func/RepeatedProc.java 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)
...c/main/java/org/cactoos/func/RepeatedCallable.java 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)
src/main/java/org/cactoos/text/Sticky.java 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e21e285...05defe4. Read the comment docs.

@andreoss andreoss marked this pull request as ready for review September 1, 2020 23:25
@victornoel
Copy link
Collaborator

@0crat status

@0crat
Copy link
Collaborator

0crat commented Sep 4, 2020

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

  • The job #1433 is in scope for 2days
  • The role is REV
  • The job is not assigned to anyone
  • The budget is not set yet
  • These users are banned and won't be assigned:
  • Job footprint (restricted area)

@victornoel
Copy link
Collaborator

@0crat assign me

victornoel
victornoel requested changes Sep 4, 2020
View reviewed changes
Copy link
Collaborator

@victornoel victornoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreoss a few comments :)

src/test/java/org/cactoos/func/UncheckedBiFuncTest.java Outdated
@@ -52,7 +52,7 @@ public void testUncheckedBiFunc() {
new UncheckedBiFunc<>(
(fst, scd) -> true
).apply(1, 2),
Matchers.equalTo(true)
new IsEqual<>(true)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreoss let's use IsTrue from cactoos-matchers here :)

src/test/java/org/cactoos/func/TimedFuncTest.java Outdated Show resolved Hide resolved
src/test/java/org/cactoos/func/TimedFuncTest.java Outdated Show resolved Hide resolved
victornoel
victornoel approved these changes Sep 4, 2020
View reviewed changes
Copy link
Collaborator

@victornoel victornoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreoss thank you :)

@victornoel
Copy link
Collaborator

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Sep 4, 2020

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 02f7902 into yegor256:master Sep 4, 2020
@rultor
Copy link
Collaborator

rultor commented Sep 4, 2020

@rultor merge

@victornoel Done! FYI, the full log is here (took me 10min)

@0crat
Copy link
Collaborator

0crat commented Sep 4, 2020

Job was finished in 2 hours, bonus for fast delivery is possible (see §36)

@0crat 0crat removed the 0crat/scope label Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victornoel victornoel victornoel approved these changes

Assignees

@victornoel victornoel

Labels
0crat/role/REV
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andreoss @codecov-commenter @victornoel @0crat @rultor