Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1434) Replace calls to Matchers with their OO counterparts #1581

Merged
merged 3 commits into from
Apr 14, 2021

Conversation

baudoliver7
Copy link
Contributor

For #1434 :

  • Replace calls to Matchers for test package com.cactoos.io

@baudoliver7
Copy link
Contributor Author

@andreoss Please, see my changes.

@baudoliver7
Copy link
Contributor Author

@andreoss Please, see my changes.

@baudoliver7
Copy link
Contributor Author

@victornoel Could you please check/merge ? @andreoss approved changes.

@victornoel
Copy link
Collaborator

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Apr 14, 2021

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 9f33693 into yegor256:master Apr 14, 2021
@rultor
Copy link
Collaborator

rultor commented Apr 14, 2021

@rultor merge

@victornoel Done! FYI, the full log is here (took me 9min)

@0crat 0crat added the qa label Apr 14, 2021
@0crat
Copy link
Collaborator

0crat commented Apr 14, 2021

@sereshqua/z please review this job completed by @andreoss/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat
Copy link
Collaborator

0crat commented Apr 14, 2021

Code review was too long (8 days), architects (@victornoel) were penalized, see §55

@0crat 0crat removed the 0crat/scope label Apr 14, 2021
@sereshqua
Copy link

@andreoss please make sure you will find at least 3 issues during next CR, thanks

@sereshqua
Copy link

@0crat quality acceptable

@baudoliver7 baudoliver7 deleted the in_continuation_of_#588 branch January 15, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants