fs.test.ts: Improve readbility, add types to fix TS problems #1482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #1481
Improve readability to make it easier for readers to use tests to understand the generator code / use the tests as specifications
Fix TypeScript problems: Added, defined types where needed.
Data
type for templates, had to explicitly include@types/ejs
andejs
in the package.GeneratorOptions
requireshelp:
be included; added it to a new Generator.... call where it was missing@ts-expect-error
comment for a line whereesmocha.spyOn(...)
is used. I referenced the known GitHub issue. I added a comment noting that the spyOn could be replaced with a sinonStub(), since the result of the spy is never checked.I did not squash my commits. I thought it might be helpful to see exactly what changes I made.