Last update for warp 3.3.30 #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Vlix
commented
Oct 13, 2023
•
Vlix
commented
- Update the Changelog.md file with a link to your PR
- Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)
…count up to 2.1GB on 32-bit machines)
| @@ -10,7 +8,7 @@ import Network.Wai.Handler.Warp.Buffer | |||
| import Network.Wai.Handler.Warp.Imports | |||
| import Network.Wai.Handler.Warp.Types | |||
|
|
|||
| toBufIOWith :: Int -> IORef WriteBuffer -> (ByteString -> IO ()) -> Builder -> IO Int | |||
| toBufIOWith :: Int -> IORef WriteBuffer -> (ByteString -> IO ()) -> Builder -> IO Integer | |||
There was a problem hiding this comment.
Isn't Int64 good enough?
There was a problem hiding this comment.
Would also be fine, but then we'd have to fromIntegral it to Integer at the next step anyway. So thought, why not just do Integer immediately.
EDIT: This reminded me I hadn't actually removed the fromIntegral, I've done that now.
|
Removed the |
|
Merged. Thanks! |
|
Tagged commit as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.