Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wai request modifying functions #952

Merged
merged 7 commits into from
Oct 27, 2023
Merged

wai request modifying functions #952

merged 7 commits into from
Oct 27, 2023

Conversation

Vlix
Copy link
Contributor

@Vlix Vlix commented Oct 26, 2023 •
edited
Loading

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Wanted to implement the long-standing #710 PR, and found some parts to also update in documentation and just code cleanup.

kazu-yamamoto
kazu-yamamoto approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

@kazu-yamamoto kazu-yamamoto merged commit 58c8e69 into yesodweb:master Oct 27, 2023
15 checks passed
@Vlix Vlix deleted the wai-request-functions branch October 27, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazu-yamamoto kazu-yamamoto kazu-yamamoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vlix @kazu-yamamoto