-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Indexmap Dependency and Enable Dependabot. #22
Conversation
Could you please review this and release a new version with the updated dependency? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesnt seem to be much to review ^_^
@futursolo to avoid getting blocked like that again, do you mind if I add you to the crate owner? |
Released in 0.3.7 |
@futursolo do you think we should relax the version to >= 1 and <= 2? |
I have relaxed the dependency and yield the release 0.3.7 because I think it can cause issues for yew users. Released 0.3.8 with relaxed version |
I do not think this is fixed with v0.3.8.
Would it be possible to publish implicit-clone with indexmap v2 as v0.4 instead as this is a breaking change? |
Yes I guess it creates those cases where you need to set a specific version in your lockfile. I had the same issue with serde and the likes recently on a different project. https://github.com/rust-disk-partition-management/gptman/pull/112/files I'll bump the minor and yank that one. |
I yanked 0.3.8. So only 0.3.6 is still available with indexmap 1.x. And I released 0.4.0 which has indexmap 2.x |
This pull request: