Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added how to use tailwind with yew using trunk #3384

Merged
merged 5 commits into from
Sep 2, 2023

Conversation

404salad
Copy link
Contributor

Description

Added how to use tailwind with yew in documentation.
Very helpful for beginners like me.

Checklist

  • [ ✓] I have reviewed my own code

Added how to use tailwind css with yew
@github-actions
Copy link

github-actions bot commented Aug 24, 2023

Visit the preview URL for this PR (updated for commit e8cab99):

https://yew-rs--pr3384-master-4160cm15.web.app

(expires Fri, 08 Sep 2023 05:33:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the PR!

While I understand why adding tailwind is a good thing, I don't want to recommend CDN as the only to use tailwind. The process of using the CLI is too convoluted to be mentioned in one line and completely unrelated to Yew.

website/versioned_docs/version-0.20/more/css.mdx Outdated Show resolved Hide resolved
@404salad
Copy link
Contributor Author

makes sense thanks!

Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that Trunk has an example. Can you update the PR to link to yew-tailwind example from trunk

@404salad 404salad changed the title Added how to use tailwind with yew Added how to use tailwind with yew using trunk Sep 1, 2023
@404salad 404salad requested a review from ranile September 1, 2023 05:17
@404salad
Copy link
Contributor Author

404salad commented Sep 1, 2023

Added to the next version of docs please let me know if it needs to be in the versioned docs 0.20 instead of the latest docs

Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! It's all good now

@ranile ranile enabled auto-merge (squash) September 1, 2023 09:40
@ranile ranile merged commit 6b9d196 into yewstack:master Sep 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants