Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct error doc test #3404

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Conversation

moyeah
Copy link
Contributor

@moyeah moyeah commented Sep 18, 2023

Description

Tests Website Snippets

Remove error: doctest failed, to rerun pass -p website-test --doc

@github-actions
Copy link

github-actions bot commented Sep 18, 2023

Visit the preview URL for this PR (updated for commit 3086341):

https://yew-rs--pr3404-correct-error-doc-te-rt52d2xa.web.app

(expires Sat, 30 Sep 2023 12:30:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@ranile
Copy link
Member

ranile commented Sep 21, 2023

Can you please ensure your PRs don't include unwanted commits? I looked through the PRs and they includes commits unrelated to that specific PR. If they must be looked at/merged in order, please do mention so in the description

@moyeah
Copy link
Contributor Author

moyeah commented Sep 21, 2023

@hamza1311 thank you for the not.
Need to merge in order.
The PR were always made form the previous PR branch and not from master.

@ranile
Copy link
Member

ranile commented Sep 22, 2023

@moyeah would you mind rebasing them off master so it's easier to review and merge them individually?

Changes to be committed:
	modified:   website/docs/migration-guides/yew/from-0_18_0-to-0_19_0.mdx
Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased it off master so it only includes the doc test fix. I'll merge it once CI is green

@ranile ranile merged commit b71dbfe into yewstack:master Sep 23, 2023
4 checks passed
@moyeah moyeah deleted the correct-error-doc-test branch September 23, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants