Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup examples/function_todomvc/src/main.rs #3413

Merged
merged 3 commits into from
Sep 30, 2023
Merged

Conversation

ronanM
Copy link
Contributor

@ronanM ronanM commented Sep 23, 2023

Add function make_callback().

Add function `make_callback()`.
Removed `.clone()`.
@github-actions
Copy link

github-actions bot commented Sep 23, 2023

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 102.825 102.825 0 0.000%
boids 175.604 175.604 0 0.000%
communication_child_to_parent 95.303 95.303 0 0.000%
communication_grandchild_with_grandparent 109.043 109.043 0 0.000%
communication_grandparent_to_grandchild 105.716 105.716 0 0.000%
communication_parent_to_child 92.788 92.788 0 0.000%
contexts 113.442 113.442 0 0.000%
counter 89.198 89.198 0 0.000%
counter_functional 89.933 89.933 0 0.000%
dyn_create_destroy_apps 92.316 92.316 0 0.000%
file_upload 103.513 103.513 0 0.000%
function_memory_game 174.578 174.578 0 0.000%
function_router 353.837 353.837 0 0.000%
function_todomvc 163.492 163.435 -0.058 -0.035%
futures 227.444 227.444 0 0.000%
game_of_life 112.162 112.162 0 0.000%
immutable 188.792 188.792 0 0.000%
inner_html 85.978 85.978 0 0.000%
js_callback 113.463 113.463 0 0.000%
keyed_list 201.202 201.202 0 0.000%
mount_point 89.188 89.188 0 0.000%
nested_list 114.614 114.614 0 0.000%
node_refs 96.290 96.290 0 0.000%
password_strength 1720.991 1720.991 0 0.000%
portals 98.359 98.359 0 0.000%
router 319.798 319.798 0 0.000%
simple_ssr 144.235 144.235 0 0.000%
ssr_router 391.595 391.595 0 0.000%
suspense 119.060 119.060 0 0.000%
timer 91.742 91.742 0 0.000%
timer_functional 100.449 100.449 0 0.000%
todomvc 143.686 143.686 0 0.000%
two_apps 89.895 89.895 0 0.000%
web_worker_fib 138.881 138.881 0 0.000%
web_worker_prime 190.359 190.359 0 0.000%
webgl 88.501 88.501 0 0.000%

✅ None of the examples has changed their size significantly.

Copy link
Member

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good to me.

Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@ranile ranile merged commit 1485f0e into yewstack:master Sep 30, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants