Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dependency on boolinator #3420

Merged
merged 4 commits into from
Sep 29, 2023

Conversation

its-the-shrimp
Copy link
Contributor

Description

The crate boolinator doesn't provide any real value, except for increasing the number of dependencies and the amount of code needed to be compiled.

Checklist

  • I have reviewed my own code
  • I have added tests

@github-actions
Copy link

github-actions bot commented Sep 27, 2023

Visit the preview URL for this PR (updated for commit e3f5b9f):

https://yew-rs-api--pr3420-remove-boolinator-0i6gyfev.web.app

(expires Wed, 04 Oct 2023 14:46:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

github-actions bot commented Sep 27, 2023

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 464.367 488.323 478.779 8.489
Hello World 10 756.174 840.287 783.230 23.177
Function Router 10 2657.422 2781.605 2729.214 33.761
Concurrent Task 10 1009.529 1011.218 1010.293 0.622
Many Providers 10 1841.011 1979.819 1901.038 40.595

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 418.836 441.585 430.004 7.096
Hello World 10 757.629 812.341 786.908 15.828
Function Router 10 2693.510 2792.217 2732.458 30.336
Concurrent Task 10 1008.899 1016.549 1010.773 2.138
Many Providers 10 1785.644 1918.123 1858.079 42.021

@github-actions
Copy link

github-actions bot commented Sep 27, 2023

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 102.960 102.961 +0.001 +0.001%
boids 175.618 175.618 0 0.000%
communication_child_to_parent 95.298 95.300 +0.002 +0.002%
communication_grandchild_with_grandparent 109.034 109.040 +0.006 +0.005%
communication_grandparent_to_grandchild 105.710 105.722 +0.012 +0.011%
communication_parent_to_child 92.792 92.794 +0.002 +0.002%
contexts 113.453 113.451 -0.002 -0.002%
counter 89.196 89.197 +0.001 +0.001%
counter_functional 89.936 89.931 -0.005 -0.005%
dyn_create_destroy_apps 92.369 92.367 -0.002 -0.002%
file_upload 103.513 103.514 +0.001 +0.001%
function_memory_game 174.570 174.571 +0.001 +0.001%
function_router 353.673 353.674 +0.001 +0.000%
function_todomvc 163.505 163.507 +0.002 +0.001%
futures 227.445 227.444 -0.001 -0.000%
game_of_life 112.163 112.164 +0.001 +0.001%
immutable 188.785 188.785 0 0.000%
inner_html 85.979 85.980 +0.001 +0.001%
js_callback 113.458 113.465 +0.007 +0.006%
keyed_list 201.203 201.202 -0.001 -0.000%
mount_point 89.189 89.188 -0.002 -0.002%
nested_list 114.618 114.622 +0.004 +0.003%
node_refs 96.290 96.294 +0.004 +0.004%
password_strength 1721.062 1721.061 -0.001 -0.000%
portals 98.365 98.368 +0.003 +0.003%
router 319.654 319.676 +0.021 +0.007%
simple_ssr 144.237 144.241 +0.004 +0.003%
ssr_router 391.450 391.461 +0.011 +0.003%
suspense 119.067 119.060 -0.008 -0.007%
timer 91.745 91.745 0 0.000%
timer_functional 100.451 100.446 -0.005 -0.005%
todomvc 143.688 143.687 -0.001 -0.001%
two_apps 89.897 89.898 +0.001 +0.001%
web_worker_fib 138.871 138.877 +0.006 +0.004%
web_worker_prime 190.426 190.418 -0.008 -0.004%
webgl 88.554 88.553 -0.001 -0.001%

✅ None of the examples has changed their size significantly.

Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a very welcome change

@ranile ranile enabled auto-merge (squash) September 29, 2023 11:30
@ranile ranile added A-yew-macro Area: The yew-macro crate A-tools Area: Tools such as trunk, wasm-bindgen labels Sep 29, 2023
@ranile ranile merged commit 753bafe into yewstack:master Sep 29, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tools Area: Tools such as trunk, wasm-bindgen A-yew-macro Area: The yew-macro crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants