Fix CI for 1.80 & (partially) benchmarks #3691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Visit the preview URL for this PR (updated for commit 8eeb75c): https://yew-rs-api--pr3691-1-80-lints-si5dr0r4.web.app (expires Thu, 01 Aug 2024 14:45:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
WorldSEnder
approved these changes
Jul 25, 2024
|
I suppose there are still parts of the benchmark that need fixing, but getting the fixes for the new 1.80 lints in is already cool. |
|
1.64 ones still fails but it's too ancient to support. We really should raise msrv |
WorldSEnder
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix clippy CI for 1.80
This is the main culprit: https://blog.rust-lang.org/2024/05/06/check-cfg.html
Checklist