Fix serving of examples #3701
Merged
Fix serving of examples #3701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
specifying an absolute URL as the public base is necessary since trunk 0.19 see also trunk-rs/trunk#668
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ranile
approved these changes
Aug 3, 2024
WorldSEnder
added
A-examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying an absolute URL as the public base is necessary since trunk 0.19
Description
Currently, examples are built and served in a way that, since trunk 0.19, links to wrong paths. E.g. "boids/index.html" links to "boids/some-resource.js" . By specifying an absolute public path, the links now point to "/boids/some-resource.js". The previously worked because an implicit "/" was added the specified path.
See also trunk-rs/trunk#668 for the issue introducing this change upstream.
Fixes #3694
Checklist