Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup! Creating Dockerfile to / #1049

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

fauust
Copy link

@fauust fauust commented Aug 3, 2023

The symlink permits do build container directly from / Same as what cjdns does (that was probably updated).

Before:

~/gh/yggdrasil-go developpodman build .
Error: no FROM statement found

After:

~/gh/yggdrasil-go dockerfile-symlinkpodman build .
[1/2] STEP 1/5: FROM docker.io/golang:alpine AS builder
[1/2] STEP 2/5: COPY . /src
--> 3806ec0449ca
[1/2] STEP 3/5: WORKDIR /src
[...]

The symlink permits do build containers directly from /
Same as what cjdns does (that was probably updated).
@neilalexander
Copy link
Member

I'm a bit confused about this PR, it just deletes the file that was already there and recreates it?

@fauust
Copy link
Author

fauust commented Oct 21, 2023

@neilalexander the file is not a symlink upstream, see bellow:

git clone https://github.com/yggdrasil-network/yggdrasil-gocd yggdrasil-gostat Dockerfile 
  File: Dockerfile
  Size: 26        	Blocks: 8          IO Block: 4096   regular file
Device: 253,0	Inode: 56512594    Links: 1
Access: (0644/-rw-r--r--)  Uid: ( 1000/   faust)   Gid: ( 1000/   faust)
Access: 2023-10-21 23:46:50.526134192 +0200
Modify: 2023-10-21 23:46:48.159503703 +0200
Change: 2023-10-21 23:46:48.159503703 +0200
 Birth: -git remote add faust https://github.com/fauust/yggdrasil-gogit remote update    
[...]git checkout faust/dockerfile-symlink
[...]stat Dockerfile 
  File: Dockerfile -> contrib/docker/Dockerfile
  Size: 25        	Blocks: 0          IO Block: 4096   symbolic link
Device: 253,0	Inode: 56512594    Links: 1
Access: (0777/lrwxrwxrwx)  Uid: ( 1000/   faust)   Gid: ( 1000/   faust)
Access: 2023-10-21 23:51:44.083576574 +0200
Modify: 2023-10-21 23:51:44.070243456 +0200
Change: 2023-10-21 23:51:44.070243456 +0200
 Birth: -

GitHub interface doesn't seem to show the difference though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants