TUN vectorised reads/writes #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilalexander
force-pushed
the
neil/vectorised
branch
from
5dff306
to
e84be89
Compare
neilalexander
force-pushed
the
neil/vectorised
branch
from
ad53173
to
db60e1c
Compare
Arceliar
approved these changes
Jul 20, 2024
There was a problem hiding this comment.
LGTM modulo one function that the last commit turned into a simple method chain, so we could think about removing that and calling the underlying function directly. I'm fine with either approach, I just don't want it to be a historical accident if we keep it.
src/tun/iface.go
Outdated
| const TUN_OFFSET_BYTES = 80 // sizeof(virtio_net_hdr) | ||
|
|
||
| func (tun *TunAdapter) idealBatchSize() int { | ||
| return tun.iface.BatchSize() |
There was a problem hiding this comment.
Minor point, but now that this is just calling tun.iface.BatchSize(), we could pretty easily remove this function and call that directly. Unless you think idealBatchSize helps with readability, I'm pretty in different to this, so I'm fine with leaving it in that case.
neilalexander
force-pushed
the
neil/vectorised
branch
from
db60e1c
to
36e6831
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Wireguard dependency and updates to use new vectorised reads/writes, which should reduce the number of syscalls and improve performance.
This will only make a difference on Linux as this is the only platform for which the Wireguard TUN library supports vectorised reads/writes. For other platforms, single reads and writes will be performed as usual.