New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add csv dependency to gemspec #35

Merged

yhirano55 merged 1 commit into yhirano55:main from tnagatomi:add-csv-dependency-to-gemspec

Jan 1, 2025

Contributor

tnagatomi commented Sep 15, 2024

When this gem is loaded, warning log is outputted because 'csv' will no longer be part of the default gems starting from Ruby 3.4.0.

Example log:

❯ bin/rails middleware
/Users/tnagatomi/.local/share/mise/installs/ruby/3.3.5/lib/ruby/3.3.0/bundled_gems.rb:75: warning: /Users/tnagatomi/.local/share/mise/installs/ruby/3.3.5/lib/ruby/3.3.0/csv.rb was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.4.0.
You can add csv to your Gemfile or gemspec to silence this warning.

I added 'csv' dependency to gemspec to fix this.


          Add csv dependency to gemspec

805774f

yhirano55 approved these changes

View reviewed changes

Owner

yhirano55 left a comment

Thank you so much for your contribution and for taking the time to submit this pull request. I sincerely apologize for the delay in reviewing it.

yhirano55 merged commit 6a38f14 into yhirano55:main

tnagatomi deleted the add-csv-dependency-to-gemspec branch

January 1, 2025 20:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet