Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test new partition scheme #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yiakwy-xpu-ml-framework-team
Copy link
Owner

@yiakwy-xpu-ml-framework-team yiakwy-xpu-ml-framework-team commented May 12, 2024

Description

  • eliminate unnecessary dtype transform (aka, skip with template dtype checking if is_same<T, TCompute>()::value is true)
  • row_id_map : the previous version map "source" row id to "dest " row id, which creates uncoalesce access of global store, since "source" id is randomly located:
// "source_topK_id * num_rows + source_token_id" is actually a random number for each thread
row_id_map[source_topK_id * num_rows + source_token_id] = idx;

instead,

    remapped_key_slot[tid] = source_topK_id * num_rows + source_token_id;
    
    cg::sync(cta);

    // Store : store the row to
    row_id_map[out_idx] = remapped_key_slot[tid];

is more friendly in continuously accessing global memory

  • add row_id_map non-inverted version in permute function (demo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant