Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to the cache API required by the new reticulate cache implementation #2170

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Changes to the cache API required by the new reticulate cache implementation #2170

wants to merge 23 commits into from

Commits on Sep 11, 2022

  1. Change API of external engines' cache to be similar to the R cache

    @leogama
    leogama committed Sep 11, 2022
    Configuration menu
    Copy the full SHA
    c9e142c View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. Also check for .Rdata cache file (with results) in the lazy cache case

    @leogama
    leogama committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    ed0ead6 View commit details
    Browse the repository at this point in the history

  2. Create cache directory only before first cache check

    @leogama
    leogama committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    706ab38 View commit details
    Browse the repository at this point in the history

  3. Fix: load package (and cache) of external engine only if necessary

    @leogama
    leogama committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    82b7930 View commit details
    Browse the repository at this point in the history

  4. Pass full options to engine_cache$exists(), $load() and $save()

    @leogama
    leogama committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    8336713 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. Pass full options to engine_caches$get(); fix variable name

    @leogama
    leogama committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    19def13 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. Only return python engine cache if available, or the R cache will alw… 

    …ays be invalidated
    @leogama
    leogama committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    1070a1b View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2022

  1. Fix: purge invalid cache files after the first cache check

    @leogama
    leogama committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    ae43d23 View commit details
    Browse the repository at this point in the history

  2. Test: cache invalidation due to missing cache file

    @leogama
    leogama committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    2a1ff59 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. showWarnings = FALSE is unnecessary (xfun::dir_create() won't create … 

    …a dir if it exists)
    @yihui
    yihui committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    0b7eb4e View commit details
    Browse the repository at this point in the history

  2. let cache$load() handle custom cache engines

    @yihui
    yihui committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    8d6d9a8 View commit details
    Browse the repository at this point in the history

  3. cosmetic

    @yihui
    yihui committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    5ca33cd View commit details
    Browse the repository at this point in the history

  4. let block_cache() handle custom cache engines, too

    @yihui
    yihui committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    212bd26 View commit details
    Browse the repository at this point in the history

  5. cache_engines$get() always try to get the engine from a name, instead… 

    … of full `options`
    @yihui
    yihui committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    95b8f80 View commit details
    Browse the repository at this point in the history

  6. use paste() instead of stringr::str_dup()

    @yihui
    yihui committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    3307e76 View commit details
    Browse the repository at this point in the history

  7. the path could be a vector of length > 1

    @yihui
    yihui committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    b5e64bf View commit details
    Browse the repository at this point in the history

  8. cosmetic

    @yihui
    yihui committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    e093389 View commit details
    Browse the repository at this point in the history

  9. clean up after testing

    @yihui
    yihui committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    5330ffc View commit details
    Browse the repository at this point in the history

  10. add news and ctb

    @yihui
    yihui committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    7b3fb59 View commit details
    Browse the repository at this point in the history

  11. Merge commit '6bfffe9c1ae8c84f0f2ae07cd3c4b00876757587' 

    Conflicts:
	NEWS.md

[ci skip]
    @yihui
    yihui committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    eeaafcb View commit details
    Browse the repository at this point in the history

  12. Merged origin/master into leogama-cache-api

    @yihui
    yihui committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    5316f3d View commit details
    Browse the repository at this point in the history

  13. apply cache_engines$get() on options to return a list (of methods)

    @yihui
    yihui committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    7a6c852 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. Merge branch 'master' into cache-api

    @leogama
    leogama authored Dec 13, 2022
    Configuration menu
    Copy the full SHA
    ad99f51 View commit details
    Browse the repository at this point in the history