Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix autodep regression by #2321 (closes #2344) #2377

Merged
merged 9 commits into from
Nov 5, 2024
Merged

fix autodep regression by #2321 (closes #2344) #2377

merged 9 commits into from
Nov 5, 2024

Conversation

atusy
Copy link
Collaborator

@atusy atusy commented Oct 19, 2024 •
edited
Loading

recreating #2374.
In #2374, I pushed my branch to original repo, not my fork.

atusy
atusy commented Oct 19, 2024
View reviewed changes
tests/testit/test-cache.R Outdated Show resolved Hide resolved
yihui
yihui approved these changes Nov 4, 2024
View reviewed changes
Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

tests/testit/test-cache.R Outdated Show resolved Hide resolved
yihui
yihui approved these changes Nov 5, 2024
View reviewed changes
Copy link
Owner

@yihui yihui left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I'm abusing opts_knit to store the state instead of creating a new object.

In #2374, I pushed my branch to original repo, not my fork.

That's totally fine. Feel free to create branches in this repo if you like. I don't mind.

@yihui yihui merged commit 710a243 into yihui:master Nov 5, 2024
1 check passed
@atusy
Copy link
Collaborator Author

atusy commented Nov 5, 2024

thanks for the brush up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihui yihui yihui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

autodep regression by #2321
2 participants
@atusy @yihui