Fix tests ci-oracle.yml.

yiisoft · Jul 5, 2023 · 6d6ea0b · 6d6ea0b
1 parent 65d513e
commit 6d6ea0b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/tests/framework/db/oci/ActiveRecordTest.php b/tests/framework/db/oci/ActiveRecordTest.php
@@ -26,7 +26,6 @@ class ActiveRecordTest extends \yiiunit\framework\db\ActiveRecordTest
     public function testCastValues()
     {
         // pass, because boolean casting is not available
-        return;
         $model = new Type();
         $model->int_col = 123;
         $model->int_col2 = 456;
@@ -48,7 +47,7 @@ public function testCastValues()
         $this->assertSame('1337', trim($model->char_col));
         $this->assertSame('test', $model->char_col2);
         $this->assertSame('test123', $model->char_col3);
-        $this->assertSame(1337.42, $model->float_col);
+        $this->assertSame(3.742, $model->float_col);
         $this->assertSame(42.1337, $model->float_col2);
         $this->assertEquals('1', $model->bool_col);
         $this->assertEquals('0', $model->bool_col2);

diff --git a/tests/framework/db/oci/ConnectionTest.php b/tests/framework/db/oci/ConnectionTest.php
@@ -83,8 +83,15 @@ public function testTransactionIsolation()
         $transaction = $connection->beginTransaction(Transaction::READ_COMMITTED);
         $transaction->commit();
 
+        /* should not be any exception so far */
+        $this->assertTrue(true);
+
+
         $transaction = $connection->beginTransaction(Transaction::SERIALIZABLE);
         $transaction->commit();
+
+        /* should not be any exception so far */
+        $this->assertTrue(true);
     }
 
     /**