Skip to content

Commit

Permalink
Add compatibility with PHP 8.3 (#20074)
Browse files Browse the repository at this point in the history
  • Loading branch information
terabytesoftw authored Nov 23, 2023
1 parent 6fdb805 commit d43341a
Show file tree
Hide file tree
Showing 7 changed files with 65 additions and 55 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ jobs:
extensions: apcu, curl, dom, imagick, intl, mbstring, mcrypt, memcached
coverage: none
os: ubuntu-latest
- php: 8.3
extensions: apcu, curl, dom, imagick, intl, mbstring, mcrypt, memcached
coverage: none
os: ubuntu-latest

steps:
- name: Generate french locale.
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/ci-mssql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ jobs:
mssql: server:2019-latest
- php: 8.2
mssql: server:2022-latest
- php: 8.3
mssql: server:2022-latest

services:
mssql:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-mysql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ jobs:
- 8.0
- 8.1
- 8.2
- 8.3

mysql:
- 5.7
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/ci-pgsql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ jobs:
- 7.4
- 8.0
- 8.1
- 8.2
- 8.3

pgsql:
- 10
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-sqlite.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ jobs:
- 8.0
- 8.1
- 8.2
- 8.3

steps:
- name: Checkout.
Expand Down
108 changes: 54 additions & 54 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/framework/data/BaseDataProviderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public function testGenerateId()
$rc = new \ReflectionClass(BaseDataProvider::className());
$rp = $rc->getProperty('counter');
$rp->setAccessible(true);
$rp->setValue(null);
$rp->setValue(new ConcreteDataProvider(), null);

$this->assertNull((new ConcreteDataProvider())->id);
$this->assertNotNull((new ConcreteDataProvider())->id);
Expand Down

0 comments on commit d43341a

Please sign in to comment.