Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests, clean workflows, separate tests db, use codecov for code coverage. #19883

Merged
merged 24 commits into from
Jul 10, 2023
Merged

Fix tests, clean workflows, separate tests db, use codecov for code coverage. #19883

merged 24 commits into from
Jul 10, 2023

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Jul 6, 2023

PR Summary

  • Updated Testing Process Across Different Platforms
    The modification done in various .github/workflows/*.yml files helps the platform support and test against new PHP versions. This ensures that our application runs smoothly across different versions of PHP.

  • Added NodeJS and Sqlite Testing Workflows
    The new files, .github/workflows/ci-node.yml and .github/workflows/ci-sqlite.yml, have been added to provide testing environments for NodeJS and Sqlite, respectively, expanding our test coverage to these environments.

  • Improved Cache Testing
    Updates to the ApcCacheTest.php file enable better handling and testing of caching, specifically when the apcu extension is used, which helps in making the cache management more robust.

  • Better Handling of Database Version Variation
    Changes to the DeadLockTest.php file result in improved handling of differing database server version. The updated code evaluates the server version before performing specific operations, and adjusts its functionality accordingly. This ensures compatibility with a wider range of server versions.

Please note that these changes focus strictly on increasing performance and application robustness, and should not directly affect application functionality as experienced by end users.

@terabytesoftw terabytesoftw added the status:code review The pull request needs review. label Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@b073daa). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #19883   +/-   ##
=========================================
  Coverage          ?   48.83%           
=========================================
  Files             ?      445           
  Lines             ?    42755           
  Branches          ?        0           
=========================================
  Hits              ?    20881           
  Misses            ?    21874           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@samdark samdark added this to the infrastructure milestone Jul 6, 2023
@terabytesoftw
Copy link
Member Author

@bizley @samdark Add a condition, so that jobs are not canceled on the master branch, so we don't have failed jobs in the history, and they will always run.

@bizley
Copy link
Member

bizley commented Jul 7, 2023

It's ok, although I don't see the point since it only cancels other jobs when one failed - so it will just run longer and we will see probably more failed jobs.

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/ci-mssql.yml Outdated Show resolved Hide resolved
.github/workflows/ci-mssql.yml Outdated Show resolved Hide resolved
.github/workflows/ci-mssql.yml Outdated Show resolved Hide resolved
.github/workflows/ci-mysql.yml Outdated Show resolved Hide resolved
.github/workflows/ci-node.yml Outdated Show resolved Hide resolved
.github/workflows/ci-sqlite.yml Outdated Show resolved Hide resolved
.github/workflows/ci-sqlite.yml Outdated Show resolved Hide resolved
.github/workflows/ci-sqlite.yml Outdated Show resolved Hide resolved
.github/workflows/ci-node.yml Outdated Show resolved Hide resolved
@samdark samdark merged commit b9e5a87 into yiisoft:master Jul 10, 2023
@samdark
Copy link
Member

samdark commented Jul 10, 2023

Awesome job. Thank you!

btw., do we need to update badges in README?

@terabytesoftw terabytesoftw deleted the fix-tests branch July 10, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants