Added 'zh' into 'framework/messages/config.php' #19995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nabi <[email protected]>
PR Summary
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #19995 +/- ##
==========================================
+ Coverage 48.94% 48.96% +0.02%
==========================================
Files 445 445
Lines 42817 42839 +22
==========================================
+ Hits 20956 20978 +22
Misses 21861 21861
☔ View full report in Codecov by Sentry. |
|
Fallback should've covered it already. Did you have any problems with the current |
|
As you can see, I have changed only one file. I didn't test the overall configuration of the framework and I don't know why it gave missing coverage! |
|
I mean functionality, not coverage. When |
Signed-off-by: Nabi <[email protected]>
|
I did that, now we only have |
|
Thanks. |
samdark
added a commit
that referenced
this pull request
Oct 19, 2023
* added pcntl to requirements check * Fix #13920: Fixed erroneous validation for specific cases * Fix #13920: Added my name to CHANGELOG.md * trim(): Passing null to parameter #1 ($string) of type string is deprecated * Added section about Unsafe Reflection in Security best practices doc (#19948) Co-authored-by: Bizley <[email protected]> * Update CHANGELOG.md * Fixed tests. * Fix #13920: Add unit test * Update `bower-asset/inputmask`, `bower-asset/punycode`. * added CHANGELOG line * Fix order. * fix: #19978 - Mistake in Korean translation * fix: keep doublequote * Do not duplicate log messages in memory * Update framework/log/FileTarget.php Co-authored-by: Bizley <[email protected]> * Update concept-di-container.md Сслка "Конфигурация приложения" была не верной, она вела на страницу "Service-locator'a" * Update CHANGELOG.md * release version 2.0.49.1 * prepare for next release * Revert changes in `mimeTypes.php` from 4a1f2c6 restores #19936 * update actions/checkout to v4 * Fix mime type generator * Added note * Update structure-controllers.md (#20003) добавил пропущенное слово "как" * Update CHANGELOG.md 2.0.49.2 changelog * release version 2.0.49.2 * prepare for next release * New methods: BaseActiveRecord::loadRelations() and BaseActiveRecord::loadRelationsFor(). * Fixed a bug where the yii serve command would break if a custom router was supplied and it had a space in the path * Fix `MaskedInputAsset::class`. * Fix #19927: Fixed `console\controllers\MessageController` when saving translations to database: fixed FK error when adding new string and language at the same time, checking/regenerating all missing messages and dropping messages for unused languages * Added 'zh' into 'framework/messages/config.php' (#19995) --------- Co-authored-by: Tobias Munk <[email protected]> Co-authored-by: Tim Fischer <[email protected]> Co-authored-by: Tim Fischer <[email protected]> Co-authored-by: Alexander Makarov <[email protected]> Co-authored-by: Oleg Poludnenko <[email protected]> Co-authored-by: Bizley <[email protected]> Co-authored-by: Sonia Zorba <[email protected]> Co-authored-by: Tobias Munk <[email protected]> Co-authored-by: Akbar Herlambang <[email protected]> Co-authored-by: lubosdz <[email protected]> Co-authored-by: Yuriy Bachevskiy <[email protected]> Co-authored-by: Robert Korulczyk <[email protected]> Co-authored-by: salehhashemi1992 <[email protected]> Co-authored-by: PowerGamer1 <[email protected]> Co-authored-by: Brad Bell <[email protected]> Co-authored-by: Alexandru Trandafir Catalin <[email protected]> Co-authored-by: Nabi KaramAliZadeh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
zhdirectory there is in theframework/messagespath, but it was not added in theconfig.phpfile. That I did. (maybe thezhfolder needed to be deleted, which needs to be checked)