-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise version min PHP 7.3
.
#20134
Raise version min PHP 7.3
.
#20134
Conversation
terabytesoftw
commented
Mar 20, 2024
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ✔️ |
Breaks BC? | ❌ |
|
Co-authored-by: Robert Korulczyk <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20134 +/- ##
=============================================
+ Coverage 46.85% 64.82% +17.96%
- Complexity 0 11376 +11376
=============================================
Files 445 429 -16
Lines 43909 37074 -6835
=============================================
+ Hits 20575 24034 +3459
+ Misses 23334 13040 -10294 ☔ View full report in Codecov by Sentry. |
…n `ContainerTest.php`.
…ons()` to `assertTrue(true)` for code coverage.
@rob006 You still think 7.3 will be useful here. |
@terabytesoftw What would be practical benefit of raising requirements to PHP 7.4? Yii 2.0 is in maintenance mode, we won't add new features and we can't refactor existing code using types because it would be a BC break (and probably a massive waste of time - such changes make more sense for Yii 2.2). So what features of PHP 7.4 would be so useful that it would be worth to cut ~5% of userbase? |
I think we should then:
With this we must have all the tests in green, review more |
I think we could skip |
Yes, let's go to 2.0.50 finally. |
Ok then merge this PR, and the implicit null, to finish removing the PHP 8.4 deprecations. |
@samdark please approve |
Let's go :) |
Since we all approve this am merging it! |