Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dropping views in MSSQL server when running migrate/fresh #20257

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

ambrozt
Copy link
Contributor

@ambrozt ambrozt commented Sep 19, 2024

Add support for dropping views in MSSQL server when running migrate/fresh

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #20256

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.95%. Comparing base (899a833) to head (e69746b).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...ramework/console/controllers/MigrateController.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #20257      +/-   ##
============================================
- Coverage     64.96%   64.95%   -0.01%     
  Complexity    11395    11395              
============================================
  Files           430      430              
  Lines         36922    36923       +1     
============================================
- Hits          23985    23982       -3     
- Misses        12937    12941       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one. Thanks. Possible to add test for it?

framework/CHANGELOG.md Outdated Show resolved Hide resolved
@samdark samdark added this to the 2.0.52 milestone Sep 20, 2024
@samdark samdark requested review from a team September 20, 2024 10:32
Copy link
Contributor

@mtangoo mtangoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If no one else have objection, I will merge it!

@mtangoo mtangoo merged commit 62f7f12 into yiisoft:master Sep 22, 2024
84 of 87 checks passed
@mtangoo
Copy link
Contributor

mtangoo commented Sep 22, 2024

@ambrozt Thanks for your time and efforts

@ambrozt
Copy link
Contributor Author

ambrozt commented Sep 22, 2024

Good one. Thanks. Possible to add test for it?

I think the function testRefreshMigration in yiiunit\framework\console\controllers\MigrateControllerTest should already cover this scenario, although I am not sure why the test is not being run on Microsoft SQL databases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants