Update Room Names #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for yjs-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
👷 Deploy Preview for yjs-playground processing.
|
|
I also noticed that upon visiting the CodeMirror 6 Binding Demo, it tries to connect to which obviously repeatedly fails. I don't know how or where to fix that, but I still wanted to mention it somewhere. |
lawvs
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
LGTM
This issue was caused by yjs/yjs-demos@054422e
I will also address the problem with CodeMirror later, thank you very much for your enthusiasm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! 👋
I just noticed that the Playground won't sync with the demos because the room names in the default connection settings don't match with the ones the demos are currently living on.
So I updated them - but I did not test anything!
As a workaround until the names are updated, the YDocs can be synced using the customizable
y-websocketconnection setting with the respective updated room name.Then it works like a charm ✨☺️