Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storytellers #22565

Closed
wants to merge 128 commits into from
Closed

Storytellers #22565

wants to merge 128 commits into from

Conversation

ToasterBiome
Copy link
Contributor

@ToasterBiome ToasterBiome commented Aug 29, 2024

Filled out by Molti, not biome

ported from
Monkestation/Monkestation2.0#461
Monkestation/Monkestation2.0#549
Monkestation/Monkestation2.0#552
Monkestation/Monkestation2.0#622
Monkestation/Monkestation2.0#952
Monkestation/Monkestation2.0#1135
Monkestation/Monkestation2.0#1427

among others (really just sorta stole it directly from their current codebase)

Why is this good for the game?

Dynamic is less dynamic than would be ideal and requires more work to update, maintain, and improve that we have
Storytellers is both more flexible to start, and is a lot easier to understand from a coding perspective, making it far less of a resource drain on our dev team to maintain

Testing

constant work in progress

Wiki Documentation

good luck mord

🆑
rscadd: Adds the storytellers from Monke (and originally horizon)
rscdel: Expunges dynamic from the codebase
/:cl:

@ToasterBiome ToasterBiome requested a review from a team as a code owner August 29, 2024 00:03
@Yogbot-13 Yogbot-13 added Feature This adds new content to the game Fix This fixes an issue. Please link issues in fix PRs Revert / Deletion Altoids is probably mad about this Tweak This PR contains changes to the game. labels Aug 29, 2024
@ToasterBiome ToasterBiome marked this pull request as draft August 29, 2024 00:03
@github-actions github-actions bot added Admin This PR affects administrators Mapping Will result in a change to a map. labels Aug 29, 2024
@PibeCantina
Copy link
Contributor

Hopefully will make boring as hell rounds actually have something going on!!! (idk what storytellers really do)

@Cartlord
Copy link
Contributor

What are the effects of adding this feature?

@Majkl-J
Copy link
Contributor

Majkl-J commented Aug 30, 2024

Hell yea

@Moltijoe Moltijoe marked this pull request as ready for review September 11, 2024 02:14
@ToasterBiome
Copy link
Contributor Author

just use #22661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin This PR affects administrators Feature This adds new content to the game Fix This fixes an issue. Please link issues in fix PRs Revert / Deletion Altoids is probably mad about this Test Merge - Requested This PR is waiting for a test merge to be scheduled Test Merge - Scheduled This PR is waiting to be test merged Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants