-
-
Notifications
You must be signed in to change notification settings - Fork 32
Added a screen annotation tool (experimental) #154
Conversation
Hi there! I'm excited to announce that I've finally made the annotation tool production ready. I've tested it thoroughly, but there may still be some bugs that I haven't found. Would you mind taking a look at it and letting me know what you think? Any suggestions are welcome. Thanks! |
This looks really cool, thanks for your work so far! |
app/src/main/java/com/bnyro/recorder/util/CustomLifecycleOwner.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/bnyro/recorder/canvas_overlay/CanvasViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/bnyro/recorder/canvas_overlay/CanvasOverlay.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/bnyro/recorder/canvas_overlay/CanvasOverlay.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/bnyro/recorder/util/CustomViewModelStoreOwner.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/bnyro/recorder/canvas_overlay/CanvasOverlay.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/bnyro/recorder/canvas_overlay/CanvasOverlay.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/bnyro/recorder/canvas_overlay/CanvasOverlay.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/bnyro/recorder/canvas_overlay/CanvasOverlay.kt
Outdated
Show resolved
Hide resolved
This works really well! Most of my comments are only some minor formatting changes. Please also make all the strings translatable by adding them to Looks great otherwise! |
I didn't want to mess with your strings file. I just added that strings for context. I suggest you to change those strings to more formal descriptions as you like. |
Okay, makes sense!
It doesn't matter to me who of us is going to quickly add these two things, as you prefer :) |
Please use the |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry for that. I thought you'd like that |
I've seen something like that on other apps before already, and I do really like the approach. |
And our current approach should have a slightly better performance than using the extension functions because we don't recreated a |
This comment was marked as off-topic.
This comment was marked as off-topic.
Fix minor formatting issues
Add annotation tool settings to bottom sheet Switch back to using Preferences object for managing preferences
Yes, that's pretty cool! |
And thanks for your contribution! <3 |
I just added a way to annotate screen while screen recording
DEMO:
VideoConvert_2023-07-09_23-45-57.mp4