-
-
Notifications
You must be signed in to change notification settings - Fork 32
Jetpack Compose navigation + New Homescreen UI + Amoled Theme #160
Conversation
# Conflicts: # app/src/main/java/com/bnyro/recorder/ui/MainActivity.kt # app/src/main/java/com/bnyro/recorder/ui/screens/PlayerScreen.kt # app/src/main/java/com/bnyro/recorder/ui/screens/RecorderScreen.kt
Really cool changes, thanks for your work! I'm not sure what kind of formatter/linter you use, however I'd like the code to be formatted with ktlint so that the code looks consistent everywhere. Two thing I noticed:
|
I'm using the built in formatting options in android studio. (Ctrl + Alt + L) To be honest I removed the themeModel becuse it didn't work. I wasn't sure why. Maybe there's a way to override some specific colors in the material you dark theme. I will do some research on that later. |
It doesn't work because Navigation Compose doesn't handle view models properly. |
I use navigation in all my apps. but I never had this problem. Maybe this is a bug in the specific version I used. For example in my MellowMusic App I use PlayerViewModel in MainActivity.kt , FullScreenPlayer.kt and MiniPlayer |
That's strange, however in all apps I used navigation compose so far, this issue persists, no matter the version of the used dependencies I tested. |
Maybe that happens because you use viewModel as a I asked chatGPT about this and this was the response
It says that using So I bet the same thing applies for this https://stackoverflow.com/questions/68548488/sharing-viewmodel-within-jetpack-compose-navigation |
That seems like it could be the reason. |
FIxed it here. |
Oh, did you use |
I'll fix the linting with an other commit myself, thanks for your efforts! |
Hi there,
I noticed that you're using Dialogs for the settings screen and recording screen. I understand that you may have done this for convenience, or maybe you didn't expect the app to have that many settings.
So, anyway I thought it might be a better idea to use Jetpack Compose navigation to navigate between different screens, mainly the settings screen and the recordings screen.
On the home screen, I didn't like the idea of using a tiny arrow to switch between the recording screens. I think it would be better to use a Bottom Bar, which would be more self-explanatory for users.
After all that, everything looked pretty good from a user experience standpoint.
However, after moving all the icons to the top app bar, the homepage started to look a bit empty and boring. I thought to myself, "I'm gonna make this more aesthetically pleasing".
So I moved some things around and added some placeholder art. I think it makes the app look less boring, and it's a technique that I've seen Google use in their apps.
I hope you will like these changes.
By the way I made these changes as smaller commits so it will be easier for you to revert any unwanted changes.
Thank you