Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Android 14 related fixes #271

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Android 14 related fixes #271

merged 4 commits into from
Mar 11, 2024

Conversation

pvagner
Copy link
Contributor

@pvagner pvagner commented Mar 6, 2024

  • Use FOREGROUND_SERVICE_MICROPHONE permission
  • Similarly how ScreenRecorderService overrides fgServiceType property to FOREGROUND_SERVICE_TYPE_MEDIA_PROJECTION make both AudioRecorderService and LosslessRecorderService inline with this on android 14 and newer by overriding its fgServiceType to FOREGROUND_SERVICE_TYPE_MICROPHONE.
  • RecorderService: When registering receivers use the RECEIVER_EXPORTED flag to avoid security exceptions on Android 14
  • ScreenRecorderService: added onStop callback to the MediaProjection. It may possibly fix App doesn't stop recordings when device is powered off resulting in corrupted files #258.

@pvagner
Android 14 related fixes
df5f20d 
* Use FOREGROUND_SERVICE_MICROPHONE permission
* Similarly how ScreenRecorderService overrides fgServiceType property to FOREGROUND_SERVICE_TYPE_MEDIA_PROJECTION make both AudioRecorderService and LosslessRecorderService inline with this on android 14 and newer by overriding its fgServiceType to FOREGROUND_SERVICE_TYPE_MICROPHONE.
* RecorderService: When registering receivers use the RECEIVER_EXPORTED flag to avoid security exceptions on Android 14
* ScreenRecorderService: added onStop callback to the MediaProjection. It may possibly fix you-apps#258.
@pvagner
Copy link
Contributor Author

pvagner commented Mar 10, 2024

Quick tiles can't start foreground services on Android 14 so merging this is not usefull yet.
https://issuetracker.google.com/issues/299506164?pli=1

Bnyro
Bnyro approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@Bnyro Bnyro merged commit 1aee6a9 into you-apps:main Mar 11, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bnyro Bnyro Bnyro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App doesn't stop recordings when device is powered off resulting in corrupted files
2 participants
@pvagner @Bnyro