Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more and improved resize options #170

Merged
merged 3 commits into from
Jan 12, 2024
Merged

feat: more and improved resize options #170

merged 3 commits into from
Jan 12, 2024

Conversation

Bnyro
Copy link
Member

@Bnyro Bnyro commented Jan 11, 2024

closes #164

@Bnyro Bnyro requested a review from SuhasDissa January 11, 2024 18:44
@SuhasDissa
Copy link
Member

I have noticed a few issues with this,

  • Applying the effects doesn't seem to do any visual change (for both portrait and landscape wallpapers)
  • The app crashes when trying to process large images (especially from reddit)
  • This PR doesn't fix the original issue

    When images are applied as wallpapers, the wallpaper should show the center of the image. However, all the resize options seems to set the top left part of the image as wallpaper.

@Bnyro
Copy link
Member Author

Bnyro commented Jan 12, 2024

This PR doesn't fix the original issue

The zoom option should center it, but there's still something wrong with it apparently.

@SuhasDissa
Copy link
Member

This PR doesn't fix the original issue

The zoom option does center it.

It didnt work when I tested it

@Bnyro
Copy link
Member Author

Bnyro commented Jan 12, 2024

Oh, I see where it's crashing for some reason.

@Bnyro
Copy link
Member Author

Bnyro commented Jan 12, 2024

I've rewritten the zoom method from scratch, it does work well in my tests now.

@Bnyro
Copy link
Member Author

Bnyro commented Jan 12, 2024

Applying the effects doesn't seem to do any visual change (for both portrait and landscape wallpapers)

This has been fixed with the previous commits.

The app crashes when trying to process large images (especially from reddit)

I can't reproduce that, but I don't think that's caused by this PR.

@Bnyro Bnyro merged commit 6661ddb into main Jan 12, 2024
2 checks passed
@Bnyro Bnyro deleted the image-resizing-options branch January 12, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some cropping options
2 participants