Add domainname test

[higuruchi]

Add domainname test.
nix does't have getdomainname function, So used libc crate.

Signed-off-by: higuruchi [email protected]

[utam0k]

@higuruchi Thanks for your cool PR, but we have to wait for runc side. opencontainers/runc#3600

[yihuaf]

@higuruchi Thanks for your cool PR, but we have to wait for runc side. opencontainers/runc#3600

@utam0k I see the runc PR is now merged. Should we get this PR merged as well? @higuruchi do you have time to follow up? If not, I can help to clean this PR up and get it merged.

[utam0k]

@yihuaf We neet to wait for the release from runc's side. Thanks for your catch-up 🙏

[YJDoc2]

@utam0k I think we can proceed with now? Or is runc release with this is still not done?

[utam0k]

@utam0k I think we can proceed with now? Or is runc release with this is still not done?

I think we can process this PR!

[YJDoc2]

@higuruchi let me know if you can continue working on this for re-basing and fixing conflicts. In case you are busy with something else or cannot work on this, I can take it up so let me know 👍

[higuruchi]

I can continue this work. Thank you for letting me know.

[YJDoc2]

I think this got duplicated in the master merge, and clippy is giving error...

[codecov-commenter]

Codecov Report

Merging #1544 (824e1fb) into main (2723aa4) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1544   +/-   ##
=======================================
  Coverage   65.50%   65.50%           
=======================================
  Files         133      133           
  Lines       16916    16916           
=======================================
  Hits        11081    11081           
  Misses       5835     5835           

[higuruchi]

@YJDoc2

integration_tests_validation fails because the latest version of runc, v1.1.8, seems does not include domain name pull request. If i run the tests on the main branch binary, they will all pass. Wait for the domain name pull request to be added to the new release?

[YJDoc2]

I think they are waiting for a minor release to roll the domainname feature out, and recent releases have been patch , so they didn't include it. I guess we will simply have to wait. @utam0k wdyt? Should we instead move to the main branch with a fixed sha or only use releases? I feel releases would be better because that is what actually being shipped.

[YJDoc2]

@higuruchi May I ask you to rebase it to current master and do the following to fix the failing runc test :
keep everything same, but comment out the addition of the test in main.rs . I'll make it work for both in a separate PR later.
If you are busy with something else, I can take this up and do the necessary changes, let me know.
Thanks a lot 🙏

[higuruchi]

@higuruchi May I ask you to rebase it to current master and do the following to fix the failing runc test : keep everything same, but comment out the addition of the test in main.rs . I'll make it work for both in a separate PR later. If you are busy with something else, I can take this up and do the necessary changes, let me know. Thanks a lot 🙏

@YJDoc2
I can't make any changes to youki at the moment, so would you mind if I ask you to make a correction?

[YJDoc2]

I can't make any changes to youki at the moment, so would you mind if I ask you to make a correction?

No worries, I'll take care of this. Thanks a lot for the contributions 🙏

[higuruchi]

I can't make any changes to youki at the moment, so would you mind if I ask you to make a correction?

No worries, I'll take care of this. Thanks a lot for the contributions 🙏

Thanks a lot 🙏

[utam0k]

LGTM. Please fix the conflict.

[YJDoc2]

Thanks a lot @utam0k for review!
Thanks @higuruchi for adding this, and apologies, it took us so long to get this merged 🙏