Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Releases needs approval from the maintainer #2583

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Dec 21, 2023

We have already introduced an automatic release workflow. But it leads to accidents. Now we merge #2582 and will start our release workflow.

I'd like to prevent it by reviewing the deployment flow.
https://docs.github.com/en/actions/managing-workflow-runs/reviewing-deployments

@utam0k utam0k added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 21, 2023
@utam0k utam0k requested a review from a team December 21, 2023 11:57
@utam0k utam0k enabled auto-merge (squash) December 21, 2023 12:03
@YJDoc2
Copy link
Collaborator

YJDoc2 commented Dec 21, 2023

Hey, so this will not run the release CI, however the tag PR would still run right? Also, are we doing 0.3.2 release immediately?

@codecov-commenter
Copy link

Codecov Report

Merging #2583 (2f8007b) into main (ff79c54) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2583      +/-   ##
==========================================
- Coverage   65.88%   65.87%   -0.02%     
==========================================
  Files         133      133              
  Lines       16819    16819              
==========================================
- Hits        11082    11080       -2     
- Misses       5737     5739       +2     

@utam0k
Copy link
Member Author

utam0k commented Dec 21, 2023

Also, are we doing 0.3.2 release immediately?

I don't have a plan.

Hey, so this will not run the release CI, however the tag PR would still run right?

Yes, but this PR prevents the release workflow without approval. Frankly, it is not so much a question of an accidental tag in itself being created.

@utam0k utam0k merged commit 85ec6d0 into youki-dev:main Dec 21, 2023
28 checks passed
@github-actions github-actions bot mentioned this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants