Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add id mount #2833

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

lengrongfu
Copy link
Collaborator

Fixes: #2307

Signed-off-by: lengrongfu <[email protected]>
@lengrongfu lengrongfu marked this pull request as draft June 27, 2024 10:02
@YJDoc2
Copy link
Collaborator

YJDoc2 commented Sep 20, 2024

@lengrongfu ping!

@lengrongfu
Copy link
Collaborator Author

@lengrongfu ping!

Pong, I will continue to work.

@utam0k
Copy link
Member

utam0k commented Dec 24, 2024

@lengrongfu Do you have any trouble? I can help you.

@lengrongfu
Copy link
Collaborator Author

@lengrongfu Do you have any trouble? I can help you.

https://github.com/opencontainers/runc/blob/d48d9cfefcdc13862ade35fd2df428cf9798bf22/libcontainer/process_linux.go#L459

Wo refer to this code, it use goroutine to recive init process callback to main process, then main process get id mapping in sending to init process. in Rust wu use thread to imple similar logic, not sure if this is correct?

After testing, I found an idmapp error. I think there is a problem with this part of the implementation.

@utam0k
Copy link
Member

utam0k commented Dec 30, 2024

Wo refer to this code, it use goroutine to recive init process callback to main process, then main process get id mapping in sending to init process. in Rust wu use thread to imple similar logic, not sure if this is correct?

@lengrongfu
We have the pipes for connection between each process (main, init, intermediate). How about using it? We have similar logic in uid mapping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support idmapped mount
3 participants