Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: 1480-increase-activity-bulk-publishing-limit-from-10-to-100 #1568

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PG-Momik
Copy link
Collaborator

No description provided.

@PG-Momik PG-Momik linked an issue Sep 23, 2024 that may be closed by this pull request
6 tasks
Copy link

what-the-diff bot commented Sep 23, 2024

## PR Summary

* **Improved Activity File Size Management**
    * Added a command to update file sizes of all published activities in batches.
    * Introduced an exception class to handle file size limit errors and integrated it into activity validation process.
    * The model for published activities now includes a file size attribute, and a table was added to the database accordingly.

* **Expanded Activity Fetch Limits**
    * Increased the default limit for fetching activities from 10 to 100, improving efficiency of data loading.

* **Enhanced Bulk Activity Publishing**
    * New logic was implemented to handle bulk activity publishing based on their draft status, making the process more robust.

* **Simplified State Check**
    * The check for the organizational state was simplified, enhancing efficiency and speed of the application.

* **Improved Validation for Multiple Activities**
    * A new job class was introduced for efficient validation of multiple activities, including managing file size checks.

* **Adjusted Error Handling Mechanisms**
    * Adjusted error types for validation responses, allowing more comprehensive and descriptive error feedback.
    * Different error types are now captured and displayed in the validation status, making the error reports more informative.
    * A state property was added to manage global error types, making error handling more consistent across the application.
    * The display logic of error types was added into Bulk Publish Vue Components for better user feedback.

* **Enhanced Table Selection Mechanism**
    * The select all functionality logic in tables was made more robust with an additional check for selected activities, providing a greater user experience.

* **Updated Automation Testing and Syntax Improvements**
    * Introduced a test file to display error mapping functionality.
    * The TypeScript target was updated for better syntax features, enhancing code readability and maintainability.

@PG-Momik PG-Momik force-pushed the 1480-increase-activity-bulk-publishing-limit-from-10-to-100 branch 2 times, most recently from d98cb24 to e09da2a Compare September 25, 2024 07:27
@PG-Momik PG-Momik force-pushed the 1480-increase-activity-bulk-publishing-limit-from-10-to-100 branch from e9a4cb6 to 6e5ce20 Compare November 5, 2024 07:28
- [x] Moved duplicate command
- [x] Disabled published button if user select 100+ activities
- [x] Test on dev
- [x] Ideal solution
@PG-Momik PG-Momik force-pushed the 1480-increase-activity-bulk-publishing-limit-from-10-to-100 branch from 6e5ce20 to 5ab5408 Compare November 5, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase activity bulk publishing limit from 10 to 100
2 participants