Skip to content

Commit

Permalink
Remove empty step, minor polish
Browse files Browse the repository at this point in the history
  • Loading branch information
oxve committed Sep 19, 2024
1 parent c3230d6 commit 4dde62e
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions .github/actions/on_device_tests/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ runs:
gsutil cp "${GCS_RESULTS_PATH}/${COBALT_XMLS_FILENAME}" . || true
# Break if the files were downloaded.
if [[ -f "${COBALT_ERROR_LOG}" && -f "${COBALT_XMLS_FILENAME}" ]]; then
if [[ -f "${COBALT_XMLS_FILENAME}" && -f "${COBALT_ERROR_LOG}" && && -f "${COBALT_INFO_LOG}" ]]; then
break
fi
Expand All @@ -124,6 +124,7 @@ runs:
# Prepare unit test results for DataDog upload.
mkdir -p ${UNIT_TEST_RESULT_PATH}/${{ matrix.platform }}/${{ matrix.shard }}/
# Set tags for test differentiation.
tags="platform:${{ matrix.platform }}"
echo $tags > ${UNIT_TEST_RESULT_PATH}/${{ matrix.platform }}/TAGS
Expand All @@ -134,11 +135,6 @@ runs:
echo "COBALT_ERROR_LOG=${COBALT_ERROR_LOG}" >> $GITHUB_ENV
echo "COBALT_INFO_LOG=${COBALT_INFO_LOG}" >> $GITHUB_ENV
shell: bash
- name: Populate TAGS for unit test report
if: always() && env.TEST_TYPE == 'unit_test'
shell: bash
run: |
# Set tags for test differentiation.
- name: Archive Unit Test Logs
uses: actions/upload-artifact@v3
if: always() && env.TEST_TYPE == 'unit_test'
Expand Down

0 comments on commit 4dde62e

Please sign in to comment.