Prototype migrating old localStorage and cookies from StorageRecord.

b/362296377
youtube · Jan 16, 2025 · 6b3ae8d · 6b3ae8d
1 parent 165ac0e
commit 6b3ae8d
Show file tree

Hide file tree

Showing 9 changed files with 474 additions and 2 deletions.
diff --git a/cobalt/BUILD.gn b/cobalt/BUILD.gn
@@ -19,6 +19,7 @@ group("gn_all") {
 
   # TODO(b/371589344): Fix android build configs.
   deps = [
+    "//cobalt/migrate_storage_record",
     "//starboard($starboard_toolchain)",
     "//starboard/nplb",
   ]
@@ -48,6 +49,7 @@ if (!is_android) {
 
     deps = [
       "//cobalt/renderer:renderer",
+      "//cobalt/migrate_storage_record",
       "//cobalt/user_agent",
       "//content/public/app",
       "//content/shell:content_shell_app",

diff --git a/cobalt/android/BUILD.gn b/cobalt/android/BUILD.gn
@@ -242,6 +242,7 @@ shared_library("libcobalt_content_shell_content_view") {
   deps = [
     ":content_shell_jni_headers",
     "//cobalt/renderer:renderer",
+    "//cobalt/migrate_storage_record",
     "//cobalt/user_agent",
 
     # TODO: what can be removed in the dependencies?

diff --git a/cobalt/cobalt_content_browser_client.cc b/cobalt/cobalt_content_browser_client.cc
@@ -16,12 +16,12 @@
 
 #include <string>
 
+#include "base/logging.h"
+#include "cobalt/migrate_storage_record/migrate.h"
 #include "cobalt/user_agent/user_agent_platform_info.h"
 #include "content/public/common/user_agent.h"
 #include "third_party/blink/public/common/web_preferences/web_preferences.h"
 
-#include "base/logging.h"
-
 namespace cobalt {
 
 #define COBALT_BRAND_NAME "Cobalt"

diff --git a/cobalt/cobalt_web_contents_observer.cc b/cobalt/cobalt_web_contents_observer.cc
@@ -14,8 +14,32 @@
 
 #include "cobalt/cobalt_web_contents_observer.h"
 
+#include "cobalt/migrate_storage_record/migrate.h"
+
 namespace cobalt {
 
+namespace {
+
+std::atomic_bool migration_attempted{false};
+
+}  // namespace
+
+void CobaltWebContentsObserver::OnCookiesAccessed(
+    content::RenderFrameHost* render_frame_host,
+    const content::CookieAccessDetails& details) {
+  if (!migration_attempted.load()) {
+    migration_attempted.store(true);
+    if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+            "clear-cookies-and-local-storage")) {
+      LOG(INFO) << "Clearing cookies and localStorage.";
+      cobalt::migrate_storage_record::ClearAll(render_frame_host);
+    } else {
+      LOG(INFO) << "Try to migrate cookies and localStorage if needed.";
+      cobalt::migrate_storage_record::Migrate(render_frame_host);
+    }
+  }
+}
+
 // Placeholder for a WebContentsObserver override
 void CobaltWebContentsObserver::PrimaryMainDocumentElementAvailable() {
   LOG(INFO) << "Cobalt::PrimaryMainDocumentElementAvailable";

diff --git a/cobalt/cobalt_web_contents_observer.h b/cobalt/cobalt_web_contents_observer.h
@@ -25,6 +25,8 @@ class CobaltWebContentsObserver : public content::WebContentsObserver {
   explicit CobaltWebContentsObserver(content::WebContents* web_contents)
       : content::WebContentsObserver(web_contents) {}
 
+  void OnCookiesAccessed(content::RenderFrameHost* render_frame_host,
+                         const content::CookieAccessDetails& details) override;
   void PrimaryMainDocumentElementAvailable() override;
 };
 

diff --git a/cobalt/migrate_storage_record/BUILD.gn b/cobalt/migrate_storage_record/BUILD.gn
@@ -0,0 +1,27 @@
+import("//testing/test.gni")
+import("//third_party/protobuf/proto_library.gni")
+
+proto_library("storage_proto") {
+  sources = [ "storage.proto" ]
+  generate_python = false
+}
+
+source_set("migrate_storage_record") {
+  # Needed to depend on |//content/shell:content_shell_lib|.
+  testonly = true
+
+  sources = [
+    "migrate.cc",
+    "migrate.h",
+  ]
+  deps = [
+    ":storage_proto",
+    "//base",
+    "//content/shell:content_shell_lib",
+    "//net",
+    "//services/network/public/mojom:cookies_mojom",
+    "//starboard/common",
+    "//url",
+  ]
+  public_deps = [ "//skia" ]
+}