Skip to content

Commit

Permalink
Cherry pick PR #3086: [android] Fix low fps checking in video_decoder…
Browse files Browse the repository at this point in the history
….cc (#3103)

Refer to the original PR: #3086

The mime attribute "framerate" is used to specify the frame rate of the
video, and the previous implementation incorrectly used "fps" as the
mime attribute name.

b/286121490

Change-Id: Iaec70f33ab625224e8a31eba96db0bea063f0a8a

Co-authored-by: xiaomings <[email protected]>
  • Loading branch information
cobalt-github-releaser-bot and xiaomings authored Apr 30, 2024
1 parent c835f70 commit 91bf579
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion starboard/android/shared/video_decoder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ bool IsSoftwareDecodeRequired(const std::string& max_video_capabilities) {

bool is_low_resolution = mime_type.GetParamIntValue("width", 1920) <= 432 &&
mime_type.GetParamIntValue("height", 1080) <= 240;
bool is_low_fps = mime_type.GetParamIntValue("fps", 30) <= 15;
bool is_low_fps = mime_type.GetParamIntValue("framerate", 30) <= 15;

if (is_low_resolution && is_low_fps) {
// Workaround to be compatible with existing backend implementation.
Expand Down

0 comments on commit 91bf579

Please sign in to comment.