Skip to content

Commit

Permalink
Fix to allow single-process on Linux. (#4290)
Browse files Browse the repository at this point in the history
This adds a fix to allow cobalt to be ran in a single_process on Linux,
and
adds the flag to the poor-man's cobalt wrapper.

b/375192642
b/374191454
  • Loading branch information
jellefoks authored Oct 25, 2024
1 parent 72d80d6 commit 9be9fc6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion base/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -2477,7 +2477,7 @@ buildflag_header("debugging_buildflags") {

# TODO(crbug.com/1420774): Try and enable these checks on Android too.
enable_commandline_sequence_checks =
(is_debug || dcheck_always_on) && !is_android
(is_debug || dcheck_always_on) && !is_android && !is_cobalt

flags = [
"DCHECK_IS_CONFIGURABLE=$dcheck_is_configurable",
Expand Down
4 changes: 2 additions & 2 deletions cobalt/cobalt.cc
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,15 @@ int main(int argc, const char** argv) {
// parameters, also update the my_argc below.
static const char* my_argv[] = {
argv[0], "--disable-fre", "--no-first-run", "--kiosk",
"--force-video-overlays",
"--force-video-overlays", "--single-process",
// Enable remote devtools access.
"--remote-debugging-port=9222",
"--remote-allow-origins=http://localhost:9222",
// This flag is added specifically for m114 and should be removed after
// rebasing to m120+
"--user-level-memory-pressure-signal-params",
"https://www.youtube.com/tv", nullptr, nullptr};
int my_argc = 9;
int my_argc = 10;

// TODO: (cobalt b/375241103) Reimplement this in a clean way.
// This expression exists to ensure that we apply the argument overrides
Expand Down

0 comments on commit 9be9fc6

Please sign in to comment.