Move IS_CI back to GitHub workflow configuration

… after commits 52b4287 and 8d9678c. Fixed: 379166386 Reviewed-on: #4611
youtube · Dec 18, 2024 · c309fb6 · c309fb6
1 parent 0cd7c8f
commit c309fb6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml
@@ -141,6 +141,7 @@ jobs:
       DEPOT_TOOLS_REPORT_BUILD: 0
       DEPOT_TOOLS_COLLECT_METRICS: 0
       DEPOT_TOOLS_METRICS: 0
+      IS_CI: 1
       SCCACHE: 1
       SCCACHE_GCS_BUCKET: cobalt-actions-sccache-linux
       SCCACHE_GCS_SERVICE_ACCOUNT: ${{ vars.SCCACHE_GCS_SERVICE_ACCOUNT }}

diff --git a/cobalt/docker/linux/Dockerfile b/cobalt/docker/linux/Dockerfile
@@ -33,9 +33,7 @@ RUN apt-get update && apt-get install -y \
 
 ADD files/sccache /usr/local/bin
 
-# TODO: b/379174067 - Move variables out of container.
 ENV SCCACHE_GCS_BUCKET=githubactions-chrome-sccache
 ENV SCCACHE_GCS_RW_MODE=READ_WRITE
 ENV SCCACHE_GCS_KEY_PATH=/root/key.json
 ENV SCCACHE_GCS_SERVICE_ACCOUNT=github-actions-bucket-access@cobalt-demo-330821.iam.gserviceaccount.com
-ENV IS_CI=1