Add tools/metrics from Chromium 114.0.5735.330 #1031
Conversation
This comment was marked as spam.
This comment was marked as spam.
There was a problem hiding this comment.
The differences may have no functional consequence, but
commit 138a0c1 doesn't match the Chromium release:
$ git diff --shortstat 138a0c14 a281dd4e:tools/metrics
4 files changed, 875 insertions(+), 3 deletions(-)
dahlstrom-g
force-pushed
the
main
branch
3 times, most recently
from
59893e3
to
9428ddb
Compare
dahlstrom-g
changed the title
dahlstrom-g
changed the title
git-subtree-dir: tools/python git-subtree-split: 4a8656d20e117967a89326daae7d5f88e0e8ebaa
git-subtree-dir: tools/metrics git-subtree-split: 4a8656d20e117967a89326daae7d5f88e0e8ebaa
|
I don't know if Joel would want this in |
dahlstrom-g
changed the title
|
I'm a bit torn on the question of this going into the 24 lts branch. This directory by itself does not impact metrics logging inside the binary. It's just a set of tools for managing histogram/user action metadata and syncing them into Piper/google3. In theory, using this directory at trunk should provide all the same benefits for someone working on the 24 branch. The only situation I could see being an issue is if someone only had access to the 24 branch outside of Google and wanted to poke around at the histogram metadata. If this use case isn't a concern, I think it just living at trunk is fine. @kaidokert thoughts? |
Also, just want to add, the decision to sync this package to 114 was intentional. It's OK this is ahead of the rest of the metrics packages. As mentioned in the comment above, this is all about metric metadata management. I want the latest here. It's OK if we're missing some histograms in the metadata files as they already are written inside Google. |
|
Can @dahlstrom-g repush again? I accidentally used this branch for another PR which wiped it. Sorry, I see what was happening. |
… from tag 114.0.5735.330.
… for tools/metrics and tools/python.
… to satisfy uses in tools/metrics.
Change-Id: I026912b352f93bd1fb15e3142f140047b988f920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4743547 Commit-Queue: Dana Dahlstrom <[email protected]> Reviewed-by: Sun Yueru <[email protected]> Reviewed-by: Robert Kaplow <[email protected]> Cr-Commit-Position: refs/heads/main@{#1179167}
… for compatibility with Python versions before 3.9, which lack PEP 585. Change-Id: Ib747d709a8762bcf81e23ddbbf6a4ec4a2c4ce97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4762987 Commit-Queue: Dana Dahlstrom <[email protected]> Reviewed-by: Weilun Shi <[email protected]> Cr-Commit-Position: refs/heads/main@{#1181199}
That use case isn't a concern, and lets agree to keep it in trunk. Another related question that if those are just tools - can't we use them directly from a Chrome checkout ? Fine either way, approving |
Nah because I'll need to make local modifications. For example, there will be a cobalt/histograms.xml file for the Cobalt specific histograms and all these scripts expect a local directory structure. |
|
Thank you Brian and Dana for working to push this through!! |
b/292142280