[media] Workaround to support video poster #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaomings
force-pushed
the
poster
branch
5 times, most recently
from
6ce5490
to
10f66ad
Compare
xiaomings
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1037 +/- ##
==========================================
+ Coverage 56.88% 56.90% +0.01%
==========================================
Files 1898 1898
Lines 94090 94107 +17
==========================================
+ Hits 53525 53553 +28
+ Misses 40565 40554 -11
|
This CL allows the web app to set a poster image for video element by: 1. Playing the video in decode-to-texture mode. 2. Setting the poster image as the background image of the video element. Previously the video background is painted to black when there are no frames to display. This isn't the expected behavior as it overwrites any background image or color settings on the video element. Now by default Cobalt won't paint the video background to black. H5vcc setting `MediaElement.PaintingVideoBackgroundToBlack` is also introduced so the web app can opt for the previous behavior, i.e. set the background to black. b/261922568
jasonzhangxx
approved these changes
Jul 26, 2023
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
This CL allows the web app to set a poster image for video element by: 1. Playing the video in decode-to-texture mode. 2. Setting the poster image as the background image of the video element. Previously the video background is painted to black when there are no frames to display. This isn't the expected behavior as it overwrites any background image or color settings on the video element. Now by default Cobalt won't paint the video background to black. H5vcc setting `MediaElement.PaintingVideoBackgroundToBlack` is also introduced so the web app can opt for the previous behavior, i.e. set the background to black. b/261922568 (cherry picked from commit a816c49)
kaidokert
pushed a commit
that referenced
this pull request
Jul 26, 2023
Refer to the original PR: #1037 This CL allows the web app to set a poster image for video element by: 1. Playing the video in decode-to-texture mode. 2. Setting the poster image as the background image of the video element. Previously the video background is painted to black when there are no frames to display. This isn't the expected behavior as it overwrites any background image or color settings on the video element. Now by default Cobalt won't paint the video background to black. H5vcc setting `MediaElement.PaintingVideoBackgroundToBlack` is also introduced so the web app can opt for the previous behavior, i.e. set the background to black. b/261922568 Co-authored-by: xiaomings <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL allows the web app to set a poster image for video element by:
Previously the video background is painted to black when there are no frames to display. This isn't the expected behavior as it overwrites any background image or color settings on the video element.
Now by default Cobalt won't paint the video background to black.
H5vcc setting
MediaElement.PaintingVideoBackgroundToBlackis also introduced so the web app can opt for the previous behavior, i.e. set the background to black.b/261922568