Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Skia from Chromium 80.0.3987.162 #1076

Merged
merged 6 commits into from
Nov 8, 2023
Merged

Update Skia from Chromium 80.0.3987.162 #1076

merged 6 commits into from
Nov 8, 2023

Conversation

dahlstrom-g
Copy link
Contributor

@dahlstrom-g dahlstrom-g commented Jul 30, 2023 •
edited
Loading

b/265870985

@rmistry @dahlstrom-g
Use same PRESUBMIT.py as master branch.
7c11019 
It was very out of date in this branch.

Bug: skia:9962
Change-Id: I78be24686a44c9c9729bd75036656bbe373af7a0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275678
Commit-Queue: Ravi Mistry <[email protected]>
Reviewed-by: Eric Boren <[email protected]>
git-subtree-dir: third_party/skia
git-subtree-split: a91f9f612e5eeb93cf40a3c0ce7d7c6ddf838feb
@google-cla

This comment was marked as outdated.

Sign in to view
@dahlstrom-g dahlstrom-g marked this pull request as draft July 30, 2023 15:00
@dahlstrom-g dahlstrom-g force-pushed the skia-80.0.3987.165 branch 3 times, most recently from 583e53e to 7f590d1 Compare August 1, 2023 21:30
@dahlstrom-g dahlstrom-g changed the title Update third_party/skia from Chromium 80.0.3987.165 Update third_party/skia from Chromium 80.0.3987.162 Oct 13, 2023
@dahlstrom-g dahlstrom-g force-pushed the skia-80.0.3987.165 branch 3 times, most recently from e68c032 to bc21ad0 Compare October 19, 2023 22:00
@dahlstrom-g dahlstrom-g marked this pull request as ready for review November 5, 2023 20:00
@dahlstrom-g dahlstrom-g changed the title Update third_party/skia from Chromium 80.0.3987.162 Update Skia from Chromium 80.0.3987.162 Nov 8, 2023
@dahlstrom-g dahlstrom-g requested review from sherryzy and removed request for kaidokert November 8, 2023 01:00
@codecov Codecov
Copy link

codecov bot commented Nov 8, 2023 •
edited
Loading

Codecov Report

Merging #1076 (20a7b0f) into main (0ce358c) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 20a7b0f differs from pull request most recent head 88b5733. Consider uploading reports for the commit 88b5733 to get more accurate results

@@            Coverage Diff             @@
##             main    #1076      +/-   ##
==========================================
+ Coverage   57.76%   57.78%   +0.01%     
==========================================
  Files        1916     1916              
  Lines       95117    95115       -2     
==========================================
+ Hits        54947    54963      +16     
+ Misses      40170    40152      -18
Files Coverage Δ
...nderer/rasterizer/skia/render_tree_node_visitor.cc 64.55% <ø> (-0.08%) ⬇️

... and 8 files with indirect coverage changes

@dahlstrom-g dahlstrom-g merged commit 901ed19 into youtube:main Nov 8, 2023
323 of 329 checks passed
@dahlstrom-g dahlstrom-g deleted the skia-80.0.3987.165 branch November 8, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherryzy sherryzy sherryzy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dahlstrom-g @sherryzy @rmistry