Set SB_IS_MODULAR=1 for any modular shared library #1169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I4e6d9fa8f9ea2068860471062e93b725a26501ef
Codecov Report
@@ Coverage Diff @@
## main #1169 +/- ##
==========================================
+ Coverage 56.54% 56.74% +0.19%
==========================================
Files 1899 1899
Lines 94144 94732 +588
==========================================
+ Hits 53237 53755 +518
- Misses 40907 40977 +70 |
andrewsavage1
requested changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/246854012
SB_IS_MODULAR needs to be set for modularly built shared libraries for starboard and cobalt toolchains, so that the symbol visibility controlled by starboard/export.h is set correctly.