Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android] Enable filtered partial audio tests #1385

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

jasonzhangxx
Copy link
Contributor

@jasonzhangxx jasonzhangxx commented Aug 23, 2023

The cl also fixed a multi thread issue of AudioFrameDiscarder and enhanced timestamp checks of audio decoder outputs.

b/274021285
b/289281412
b/292409536
b/298072842

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #1385 (f6f74f6) into main (61e7127) will decrease coverage by 0.01%.
Report is 55 commits behind head on main.
The diff coverage is 60.86%.

@@            Coverage Diff             @@
##             main    #1385      +/-   ##
==========================================
- Coverage   56.38%   56.38%   -0.01%     
==========================================
  Files        1902     1902              
  Lines       94566    94607      +41     
==========================================
+ Hits        53321    53340      +19     
- Misses      41245    41267      +22     
Files Changed Coverage Δ
...d/starboard/player/filter/audio_frame_discarder.cc 75.00% <60.86%> (-1.48%) ⬇️

... and 15 files with indirect coverage changes

The cl also enabled filtered partial audio tests.

b/274021285
b/289281412
@jasonzhangxx jasonzhangxx merged commit d927d5b into youtube:main Sep 1, 2023
342 checks passed
@jasonzhangxx jasonzhangxx added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Sep 1, 2023
@jasonzhangxx jasonzhangxx deleted the discarder2 branch September 1, 2023 20:02
cobalt-github-releaser-bot pushed a commit that referenced this pull request Sep 1, 2023
The cl also fixed a multi thread issue of AudioFrameDiscarder and
enhanced timestamp checks of audio decoder outputs.

b/274021285
b/289281412
b/292409536
b/298072842

(cherry picked from commit d927d5b)
kaidokert pushed a commit that referenced this pull request Sep 2, 2023
…1472)

Refer to the original PR: #1385

The cl also fixed a multi thread issue of AudioFrameDiscarder and
enhanced timestamp checks of audio decoder outputs.

b/274021285
b/289281412
b/292409536
b/298072842

Co-authored-by: Jason <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants