-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[android] Enable filtered partial audio tests #1385
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonzhangxx
force-pushed
the
discarder2
branch
from
August 23, 2023 23:45
d6b760e
to
ed2814b
Compare
Codecov Report
@@ Coverage Diff @@
## main #1385 +/- ##
==========================================
- Coverage 56.38% 56.38% -0.01%
==========================================
Files 1902 1902
Lines 94566 94607 +41
==========================================
+ Hits 53321 53340 +19
- Misses 41245 41267 +22
|
jasonzhangxx
force-pushed
the
discarder2
branch
5 times, most recently
from
August 28, 2023 23:25
12f12a3
to
a7f8d5c
Compare
xiaomings
reviewed
Aug 29, 2023
starboard/shared/starboard/player/filter/audio_frame_discarder.cc
Outdated
Show resolved
Hide resolved
starboard/shared/starboard/player/filter/testing/audio_decoder_test.cc
Outdated
Show resolved
Hide resolved
jasonzhangxx
force-pushed
the
discarder2
branch
from
August 30, 2023 20:50
a7f8d5c
to
4a7c024
Compare
The cl also enabled filtered partial audio tests. b/274021285 b/289281412
jasonzhangxx
force-pushed
the
discarder2
branch
from
August 30, 2023 21:19
4a7c024
to
f6f74f6
Compare
xiaomings
approved these changes
Aug 30, 2023
osagie98
reviewed
Sep 1, 2023
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Sep 1, 2023
The cl also fixed a multi thread issue of AudioFrameDiscarder and enhanced timestamp checks of audio decoder outputs. b/274021285 b/289281412 b/292409536 b/298072842 (cherry picked from commit d927d5b)
kaidokert
pushed a commit
that referenced
this pull request
Sep 2, 2023
…1472) Refer to the original PR: #1385 The cl also fixed a multi thread issue of AudioFrameDiscarder and enhanced timestamp checks of audio decoder outputs. b/274021285 b/289281412 b/292409536 b/298072842 Co-authored-by: Jason <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cl also fixed a multi thread issue of AudioFrameDiscarder and enhanced timestamp checks of audio decoder outputs.
b/274021285
b/289281412
b/292409536
b/298072842